From e699f43d0477e7767c0f91388ab52d68955a783e Mon Sep 17 00:00:00 2001 From: "opensearch-trigger-bot[bot]" <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Date: Wed, 11 Sep 2024 18:14:31 +0800 Subject: [PATCH] Fix E2E test for index-management-dashboards-plugin (#1545) (#1567) * Fix E2E test for index-management-dashboards-plugin Signed-off-by: Kshitij Tandon * feat: upgrade upload-artifact Signed-off-by: SuZhou-Joe --------- Signed-off-by: Kshitij Tandon Signed-off-by: SuZhou-Joe Co-authored-by: SuZhou-Joe (cherry picked from commit 7d0b1b5edfae3ab5a0827aca6ec91a185f412a33) Co-authored-by: Kshitij Tandon --- .github/workflows/release-e2e-workflow-template-windows.yml | 6 +++--- .github/workflows/release-e2e-workflow-template.yml | 6 +++--- .github/workflows/release-signoff-chrome.yml | 4 ++-- .github/workflows/release-signoff-chromium-ad-only.yml | 4 ++-- .github/workflows/release-signoff-chromium-ism-only.yml | 4 ++-- .../release-signoff-chromium-tests-in-memory-0.yml | 4 ++-- .../release-signoff-chromium-tests-in-memory-10.yml | 4 ++-- .../release-signoff-chromium-tests-in-memory-20.yml | 4 ++-- .../release-signoff-chromium-tests-in-memory-5.yml | 4 ++-- .github/workflows/release-signoff-chromium.yml | 4 ++-- .github/workflows/release-signoff-electron.yml | 4 ++-- .github/workflows/release-signoff-firefox.yml | 4 ++-- .../plugins/index-management-dashboards-plugin/aliases.js | 2 +- 13 files changed, 27 insertions(+), 27 deletions(-) diff --git a/.github/workflows/release-e2e-workflow-template-windows.yml b/.github/workflows/release-e2e-workflow-template-windows.yml index 31e9a0022..70a4f52a9 100644 --- a/.github/workflows/release-e2e-workflow-template-windows.yml +++ b/.github/workflows/release-e2e-workflow-template-windows.yml @@ -136,19 +136,19 @@ jobs: command: ${{ inputs.test-command }} wait-on: 'http://localhost:5601' # Screenshots are only captured on failure, will change this once we do visual regression tests - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: failure() with: name: cypress-screenshots path: cypress-test/cypress/screenshots # Test run video was always captured, so this action uses "always()" condition - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: always() with: name: cypress-videos path: cypress-test/cypress/videos # Test reports was always captured, so this action uses "always()" condition - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: always() with: name: cypress-results diff --git a/.github/workflows/release-e2e-workflow-template.yml b/.github/workflows/release-e2e-workflow-template.yml index 1d0e976d5..39ba7d795 100644 --- a/.github/workflows/release-e2e-workflow-template.yml +++ b/.github/workflows/release-e2e-workflow-template.yml @@ -132,19 +132,19 @@ jobs: command: ${{ inputs.test-command }} wait-on: 'http://localhost:5601' # Screenshots are only captured on failure, will change this once we do visual regression tests - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: failure() with: name: cypress-screenshots path: cypress-test/cypress/screenshots # Test run video was always captured, so this action uses "always()" condition - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: always() with: name: cypress-videos path: cypress-test/cypress/videos # Test reports was always captured, so this action uses "always()" condition - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: always() with: name: cypress-results diff --git a/.github/workflows/release-signoff-chrome.yml b/.github/workflows/release-signoff-chrome.yml index 2af455edf..db178778b 100644 --- a/.github/workflows/release-signoff-chrome.yml +++ b/.github/workflows/release-signoff-chrome.yml @@ -90,13 +90,13 @@ jobs: command: yarn cypress:release-chrome wait-on: 'http://localhost:5601' # Screenshots are only captured on failure, will change this once we do visual regression tests - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: failure() with: name: cypress-screenshots path: functional-test/cypress/screenshots # Test run video was always captured, so this action uses "always()" condition - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: always() with: name: cypress-videos diff --git a/.github/workflows/release-signoff-chromium-ad-only.yml b/.github/workflows/release-signoff-chromium-ad-only.yml index d4db844d9..f7a31f460 100644 --- a/.github/workflows/release-signoff-chromium-ad-only.yml +++ b/.github/workflows/release-signoff-chromium-ad-only.yml @@ -79,13 +79,13 @@ jobs: command: yarn cypress:release-ad-only wait-on: 'http://localhost:5601' # Screenshots are only captured on failure, will change this once we do visual regression tests - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: failure() with: name: cypress-screenshots path: functional-test/cypress/screenshots # Test run video was always captured, so this action uses "always()" condition - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: always() with: name: cypress-videos diff --git a/.github/workflows/release-signoff-chromium-ism-only.yml b/.github/workflows/release-signoff-chromium-ism-only.yml index 6f0d5d3d1..eae44dfb7 100644 --- a/.github/workflows/release-signoff-chromium-ism-only.yml +++ b/.github/workflows/release-signoff-chromium-ism-only.yml @@ -79,13 +79,13 @@ jobs: command: yarn cypress:release-ism-only wait-on: 'http://localhost:5601' # Screenshots are only captured on failure, will change this once we do visual regression tests - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: failure() with: name: cypress-screenshots path: functional-test/cypress/screenshots # Test run video was always captured, so this action uses "always()" condition - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: always() with: name: cypress-videos diff --git a/.github/workflows/release-signoff-chromium-tests-in-memory-0.yml b/.github/workflows/release-signoff-chromium-tests-in-memory-0.yml index 674c34d36..785a8d03f 100644 --- a/.github/workflows/release-signoff-chromium-tests-in-memory-0.yml +++ b/.github/workflows/release-signoff-chromium-tests-in-memory-0.yml @@ -79,13 +79,13 @@ jobs: command: yarn cypress:release-chromium-0 wait-on: 'http://localhost:5601' # Screenshots are only captured on failure, will change this once we do visual regression tests - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: failure() with: name: cypress-screenshots path: functional-test/cypress/screenshots # Test run video was always captured, so this action uses "always()" condition - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: always() with: name: cypress-videos diff --git a/.github/workflows/release-signoff-chromium-tests-in-memory-10.yml b/.github/workflows/release-signoff-chromium-tests-in-memory-10.yml index 8501c9e80..b521792cb 100644 --- a/.github/workflows/release-signoff-chromium-tests-in-memory-10.yml +++ b/.github/workflows/release-signoff-chromium-tests-in-memory-10.yml @@ -79,13 +79,13 @@ jobs: command: yarn cypress:release-chromium-10 wait-on: 'http://localhost:5601' # Screenshots are only captured on failure, will change this once we do visual regression tests - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: failure() with: name: cypress-screenshots path: functional-test/cypress/screenshots # Test run video was always captured, so this action uses "always()" condition - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: always() with: name: cypress-videos diff --git a/.github/workflows/release-signoff-chromium-tests-in-memory-20.yml b/.github/workflows/release-signoff-chromium-tests-in-memory-20.yml index 2a71090f6..08fce3150 100644 --- a/.github/workflows/release-signoff-chromium-tests-in-memory-20.yml +++ b/.github/workflows/release-signoff-chromium-tests-in-memory-20.yml @@ -79,13 +79,13 @@ jobs: command: yarn cypress:release-chromium-20 wait-on: 'http://localhost:5601' # Screenshots are only captured on failure, will change this once we do visual regression tests - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: failure() with: name: cypress-screenshots path: functional-test/cypress/screenshots # Test run video was always captured, so this action uses "always()" condition - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: always() with: name: cypress-videos diff --git a/.github/workflows/release-signoff-chromium-tests-in-memory-5.yml b/.github/workflows/release-signoff-chromium-tests-in-memory-5.yml index 66db12ab4..9f0477095 100644 --- a/.github/workflows/release-signoff-chromium-tests-in-memory-5.yml +++ b/.github/workflows/release-signoff-chromium-tests-in-memory-5.yml @@ -79,13 +79,13 @@ jobs: command: yarn cypress:release-chromium-5 wait-on: 'http://localhost:5601' # Screenshots are only captured on failure, will change this once we do visual regression tests - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: failure() with: name: cypress-screenshots path: functional-test/cypress/screenshots # Test run video was always captured, so this action uses "always()" condition - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: always() with: name: cypress-videos diff --git a/.github/workflows/release-signoff-chromium.yml b/.github/workflows/release-signoff-chromium.yml index 405cec501..f913198d5 100644 --- a/.github/workflows/release-signoff-chromium.yml +++ b/.github/workflows/release-signoff-chromium.yml @@ -79,13 +79,13 @@ jobs: command: yarn cypress:release-chromium wait-on: 'http://localhost:5601' # Screenshots are only captured on failure, will change this once we do visual regression tests - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: failure() with: name: cypress-screenshots path: functional-test/cypress/screenshots # Test run video was always captured, so this action uses "always()" condition - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: always() with: name: cypress-videos diff --git a/.github/workflows/release-signoff-electron.yml b/.github/workflows/release-signoff-electron.yml index 2270882ef..7758a19fd 100644 --- a/.github/workflows/release-signoff-electron.yml +++ b/.github/workflows/release-signoff-electron.yml @@ -79,13 +79,13 @@ jobs: command: yarn cypress:release-electron wait-on: 'http://localhost:5601' # Screenshots are only captured on failure, will change this once we do visual regression tests - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: failure() with: name: cypress-screenshots path: functional-test/cypress/screenshots # Test run video was always captured, so this action uses "always()" condition - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: always() with: name: cypress-videos diff --git a/.github/workflows/release-signoff-firefox.yml b/.github/workflows/release-signoff-firefox.yml index 340de6dc7..f087b39f6 100644 --- a/.github/workflows/release-signoff-firefox.yml +++ b/.github/workflows/release-signoff-firefox.yml @@ -79,13 +79,13 @@ jobs: command: yarn cypress:release-firefox wait-on: 'http://localhost:5601' # Screenshots are only captured on failure, will change this once we do visual regression tests - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: failure() with: name: cypress-screenshots path: functional-test/cypress/screenshots # Test run video was always captured, so this action uses "always()" condition - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v4 if: always() with: name: cypress-videos diff --git a/cypress/integration/plugins/index-management-dashboards-plugin/aliases.js b/cypress/integration/plugins/index-management-dashboards-plugin/aliases.js index 72442ee0b..6219893f5 100644 --- a/cypress/integration/plugins/index-management-dashboards-plugin/aliases.js +++ b/cypress/integration/plugins/index-management-dashboards-plugin/aliases.js @@ -65,7 +65,7 @@ describe('Aliases', () => { describe('can create a alias with wildcard and specific name', () => { it('successfully', () => { cy.get('[data-test-subj="Create aliasButton"]').click(); - cy.get('[data-test-subj="form-name-alias"]').type(CREATE_ALIAS); + cy.get('[data-test-subj="form-name-alias"] input').type(CREATE_ALIAS); cy.get( '[data-test-subj="form-name-indexArray"] [data-test-subj="comboBoxSearchInput"]' ).type(`${EDIT_INDEX}{enter}${SAMPLE_INDEX_PREFIX}-*{enter}`);