Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Refactoring / Code Improvements ] Incorporate naming and typing feedback from PR 477 #491

Closed
2 tasks
kartg opened this issue Jan 25, 2024 · 0 comments · Fixed by #506
Closed
2 tasks
Labels
enhancement New feature or request untriaged

Comments

@kartg
Copy link
Member

kartg commented Jan 25, 2024

This issue tracks open action items from #477 based on PR feedback from @gregschohn :

  • Rename index_operations to something that's more clear

Index is both a noun and a verb, so it isn't clear to me whether this applies to operations on indices (nouns) or if this is a set of operations of a particular type (verb). index_management.py, or something that could shake the ambiguity would probably help new contributors.

  • Use custom errors across the code base rather than a chain of RuntimeError

This stems from #477 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged
Projects
None yet
1 participant