Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy needs to be immune to the change of the time on a local proxy machine #544

Open
gregschohn opened this issue Mar 29, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@gregschohn
Copy link
Collaborator

What is the bug?

Instant.now() is used for timestamps of TrafficObservations, which doesn't guarantee monotonicity.

How can one reproduce the bug?

I haven't confirmed this scenario, but it would be a good test too. Run the proxy. Open a connection to the proxy with keep-alive enabled.

  1. Run a request through the proxy (to a backend server).
  2. Reset the clock backward on the system by a couple seconds.
  3. Send another request through.

The timestamps should be in chronological order, even if that means that the timestamp doesn't match the currently reported time of the host machine.

What is the expected behavior?

All observations within a connection will be in chronological order.

What is your host/environment?

N/A

Do you have any screenshots?

N/A

Do you have any additional context?

See Issue 536

@gregschohn gregschohn added bug Something isn't working untriaged labels Mar 29, 2024
@peternied
Copy link
Member

@gregschohn Which component should arbitrate 'time', it seems like it should be the proxy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants