Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(OUI Next Theme) Discover #919

Closed
3 tasks
Tracked by #895
KrooshalUX opened this issue Jul 25, 2023 · 1 comment · Fixed by opensearch-project/OpenSearch-Dashboards#4644
Closed
3 tasks
Tracked by #895

(OUI Next Theme) Discover #919

KrooshalUX opened this issue Jul 25, 2023 · 1 comment · Fixed by opensearch-project/OpenSearch-Dashboards#4644
Assignees

Comments

@KrooshalUX
Copy link
Contributor

KrooshalUX commented Jul 25, 2023

This issue to be transferred to corresponding repository

I am working on launching new light and dark mode themes provided by OUI component library for a target launch within 2.10. These changes support the vision expressed in Future Vision for Dashboards

I have identified the following front end related issues that prevent the theme from appearing complete and potential solutions within this feature:

  • In Next theme, Source content highlight appears too dark. Utilize sass variable (tbd) in favor of hard coded color value. Potentially utilize EuiBadge .
Screen Shot 2023-07-25 at 3 32 15 PM
  • View Surrounding Documents generates a table that utilizes colors from Current theme. These should be updated to dynamically match theme values.
Screen Shot 2023-07-25 at 3 31 01 PM
  • Visualizations utilizes colors from Current theme. Remove background and utilize ouiPaletteColorBlind for visualization colors.
Screen Shot 2023-07-25 at 3 33 41 PM
@joshuarrrr
Copy link
Member

joshuarrrr commented Jul 26, 2023

In Next theme, Source content highlight appears too dark. Utilize sass variable (tbd) in favor of hard coded color value. Potentially utilize EuiBadge .

This one is an easy fix. The reason it currently looks so bad is that they've set the opacity to just .1. It's an unnecessary use of transparency as a lazy way to further lighten the color rather than tint and shade.

View Surrounding Documents generates a table that utilizes colors from Current theme. These should be updated to dynamically match theme values.

Given the current work to refactor this view altogether for data explorer, we should pick the lowest hanging fruit here, because this page is built and styled with the legacy KUI. So I'd likely need a full mock with the correct colors, or specific styling to target, because the component refactoring is already underway.

Visualizations utilizes colors from Current theme. Remove background and utilize ouiPaletteColorBlind for visualization colors.

This is an ElasticCharts visualization, so we need to update OUI to also export a charts theme for next-dark. That will fix the background color. However, the visualization color is already correctly using the first ouiPaletteColorBlind color (via the chart theme).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants