Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] CI isn't used/reliable/circular dependency? #107

Open
dblock opened this issue Dec 20, 2021 · 1 comment
Open

[BUG] CI isn't used/reliable/circular dependency? #107

dblock opened this issue Dec 20, 2021 · 1 comment
Labels
bug Something isn't working ci good first issue Good for newcomers

Comments

@dblock
Copy link
Member

dblock commented Dec 20, 2021

What is the bug?
Something as trivial as an upgrade of a dependency or a version can't seem to be able to rely on CI. Log4j upgrade changes were merged with failures. An attempt in upgrading to 1.17 in a similar manner as a previous commit is failing CI (#106).

Screen Shot 2021-12-20 at 12 52 23 PM

What is the expected behavior?
CI should be all green for any change

Do you have any additional context?
Is this a circular dependency problem with PA?

@sruti1312
Copy link
Contributor

The recent commits 940e461 and 9fcf19fmerged into 1.2 branch (log4j and version upgrades) have failing CI due to failing integration tests (spins up a docker using docker artifacts and runs the test suite). The docker artifact was not available when this change was committed (as infra team was still working on generating the artifact). The next commit bf7f59ee updates the docker artifact link and thus have a passing CI.

On commits merged into main the CI has failures due to following reasons,

  1. Failing Link checker (which is fixed now as part of this PR)
  2. OS Snapshot not available for 1.2.2 and 1.2.3. We should update main to 1.3 instead of using minor versions.

Screen Shot 2022-01-04 at 10 56 33 AM

Currently, PA and PA-RCA have circular dependencies causing issues like failing CI's like 6cebefab9 and making release process tedious. PA-RCA is a standalone application/library that PA depends on.
PA-RCA CI's checks out PA and run its unit tests which can be removed. Additionally the integration tests which run as a part of PA-RCA CI need to be moved to PA CI's. Tracking fixing circular dependencies using the same issue.

@kkhatua kkhatua added good first issue Good for newcomers ci and removed untriaged labels Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants