Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Add Retry limit for thread setup in PerformanceAnalyzerApp. #468

Closed
khushbr opened this issue Aug 7, 2023 · 1 comment
Closed
Labels
backport 1.3 backport 2.x bug Something isn't working v2.10.0 Issues targeting release v2.10.0

Comments

@khushbr
Copy link
Collaborator

khushbr commented Aug 7, 2023

What is the bug?
Add retry limit to various thread re-start within PerformanceAnalyzerApp. Currently, createThreadForRunnable executes a while (true) loop, which in case of incorrect docker setup can lead to large retry attempts; with additional side-effect of log volume filling up with error messages - "Error in ReaderMetricsProcessor...restarting, ExceptionCode: "

            startReaderThread(appContext, THREAD_PROVIDER);
            startGrpcServerThread(clientServers.getNetServer(), THREAD_PROVIDER);
            startWebServerThread(clientServers.getHttpServer(), THREAD_PROVIDER);
            startRcaTopLevelThread(clientServers, connectionManager, appContext, THREAD_PROVIDER);

What is the expected behavior?
Bail-out strategy in case of repeated thread setup failure.

@khushbr khushbr added bug Something isn't working untriaged labels Aug 7, 2023
@khushbr khushbr changed the title [BUG] Add Retry limit for [BUG] Add Retry limit for thread setup in PerformanceAnalyzerApp. Aug 7, 2023
@khushbr khushbr added v2.10.0 Issues targeting release v2.10.0 backport 2.x backport 1.3 and removed untriaged labels Aug 7, 2023
@khushbr
Copy link
Collaborator Author

khushbr commented Sep 19, 2023

Change merged to main and 2.x, see #476

@khushbr khushbr closed this as completed Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.3 backport 2.x bug Something isn't working v2.10.0 Issues targeting release v2.10.0
Projects
None yet
Development

No branches or pull requests

1 participant