Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Build failure due to breaking changes introduced in core #2782

Closed
1 of 2 tasks
RyanL1997 opened this issue May 18, 2023 · 7 comments
Closed
1 of 2 tasks

[Refactor] Build failure due to breaking changes introduced in core #2782

RyanL1997 opened this issue May 18, 2023 · 7 comments
Assignees
Labels
bug Something isn't working triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@RyanL1997
Copy link
Collaborator

RyanL1997 commented May 18, 2023

What is the issue?

  • We need to adapt the breaking change in core OpenSearch: [Refactor] OpenSearchException and ExceptionsHelper foundation to base class OpenSearch#7508

  • Core OpenSearch has split the imports of org.opensearch.common.Strings and org.opensearch.core.common.Stringsinto two.

  • Tracking on the original toString() function, since it is not defined in org.opensearch.core.common.Strings. The current fix is:

    ...
    return org.opensearch.common.Strings.toString(JsonXContent.contentBuilder().map(getAsMap()));
    ...
    
  • LoggerMessageFormat.java location change causing SecurityFilter.java to not compile

Fixes

@RyanL1997 RyanL1997 added bug Something isn't working untriaged Require the attention of the repository maintainers and may need to be prioritized labels May 18, 2023
@DarshitChanpura DarshitChanpura changed the title [Refactor] Fix the import of org.opensearch.core.common.Strings [Refactor] Build failure due to breaking changes introduced in core May 19, 2023
@stephen-crawford
Copy link
Collaborator

stephen-crawford commented May 22, 2023

[Triage] There is a fix for this pending in core. No further action is required. @RyanL1997 can you close this issue once the changes are fully merged. Thank you.

@stephen-crawford stephen-crawford added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels May 22, 2023
@martin-gaievski
Copy link
Member

@scrawfor99 Can you please share core issue that tracks that fix you've mentioned? I've opened another issue in core, do you think it may be related to the fix opensearch-project/OpenSearch#7714?

@stephen-crawford
Copy link
Collaborator

Hi @martin-gaievski, sorry, I did not see your comment before. The original fix should be up in the body of the issue I believe. Let me know if that is not what you were looking for.

@github-actions github-actions bot added the untriaged Require the attention of the repository maintainers and may need to be prioritized label May 31, 2023
@davidlago davidlago removed the untriaged Require the attention of the repository maintainers and may need to be prioritized label May 31, 2023
@davidlago
Copy link

[Triage] Keeping open for now for tracking purposes (and if eventually any further work is needed)

@parasjain1
Copy link
Contributor

We need to backport this to 2.x.

Changes in core were backported to 2.x.
opensearch-project/OpenSearch#8460

@RyanL1997
Copy link
Collaborator Author

Hi @parasjain1, ty for the notification~ I think we did the backport here: #2953

@peternied
Copy link
Member

@RyanL1997 You have another item 'wip...' which I suspect was 'work in progress'. Doesn't look like there was anything else needed and the pull requests associated were merged and backported to 2.x -- assuming this is complete and closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Development

No branches or pull requests

6 participants