Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Backward compatibility tests failing for security plugin #2950

Closed
parasjain1 opened this issue Jul 7, 2023 · 5 comments
Closed

[BUG] Backward compatibility tests failing for security plugin #2950

parasjain1 opened this issue Jul 7, 2023 · 5 comments
Assignees
Labels
bug Something isn't working untriaged Require the attention of the repository maintainers and may need to be prioritized

Comments

@parasjain1
Copy link
Contributor

What is the bug?
Backward compatibility tests are failing for security plugin on the main branch which impacts the release quality and prevents us from catching any regressions / bugs that might creep.

How can one reproduce the bug?
Steps to reproduce the behavior:
Attaching recent PRs -

What is the expected behavior?
Backward Compatibility tests should be passing in GitHub actions.

What is your host/environment?
N/A

Do you have any screenshots?
If applicable, add screenshots to help explain your problem.

Do you have any additional context?
Tests seem to be failing due to a dependency conflict

* What went wrong:
Execution failed for task ':compileJava'.
> Could not resolve all dependencies for configuration ':compileClasspath'.
   > Conflict(s) found for the following module(s):
       - org.apache.httpcomponents:httpclient between versions 4.5.14 and 4.5.13
     Run with:
         --scan or
         :dependencyInsight --configuration compileClasspath --dependency org.apache.httpcomponents:httpclient
     to get more insight on how to solve the conflict.
@parasjain1 parasjain1 added bug Something isn't working untriaged Require the attention of the repository maintainers and may need to be prioritized labels Jul 7, 2023
@parasjain1
Copy link
Contributor Author

Raised PR for the fix - #2951

@cwperks
Copy link
Member

cwperks commented Jul 7, 2023

@parasjain1 I just opened a separate PR against the 2.x branch. I think the issue is that 2.x is explicitly referring to 4.5.13 and should instead take the version of httpclient from core's buildSrc/version.properties

@cwperks
Copy link
Member

cwperks commented Jul 7, 2023

@parasjain1 I just noticed that the head of 2.x had other compilation issues due to a backport of a refactor in core

I have raised a PR to both address the core refactor and the bwc issue: #2953

@cwperks
Copy link
Member

cwperks commented Jul 7, 2023

This is now resolved. Closing this issue.

@cwperks cwperks closed this as completed Jul 7, 2023
@parasjain1
Copy link
Contributor Author

Thanks Craig.

@cwperks cwperks self-assigned this Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged Require the attention of the repository maintainers and may need to be prioritized
Projects
None yet
Development

No branches or pull requests

2 participants