Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add new CI workflow for PRs to run tests on base branch. #1242

Open
Yury-Fridlyand opened this issue Jan 6, 2023 · 1 comment
Open
Labels
enhancement New feature or request infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.

Comments

@Yury-Fridlyand
Copy link
Collaborator

A situation might happen when a good PRs1 was merged2 into a base branch cause a failure after merge.
This happened recently with #1166.
image

Existing PR CI workflows run on top of the feature branch only. Merging PR cause a merge commit which triggers another CI which might fail, but it doesn't block the PR, because it is already merged... Furthermore, detect such failures is much more difficult in tons of GHA notifications.

The feature I request is to add a new CI workflow which will run in each PR and test proposed changes on base branch.

  1. Workflow would be like:
git checkout <base branch>
git merge <pr branch>
./gradlew ...
  1. Workflow could run simplified test suite (e.g. integration tests only).
  2. Workflow should run on every change in base or feature branch, see pull_request_target

Footnotes

  1. All CI passed on feature branches

  2. Without any conflicts

@Yury-Fridlyand Yury-Fridlyand added enhancement New feature or request infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. labels Jan 6, 2023
@YANG-DB
Copy link
Member

YANG-DB commented Jan 9, 2023

Hi
Totally agree - I also believe that the more complex system tests which call external resources like Prometheus should not be part of these acceptance tests but run after ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

No branches or pull requests

2 participants