-
Notifications
You must be signed in to change notification settings - Fork 310
/
nodepool_controller.go
1466 lines (1321 loc) · 57 KB
/
nodepool_controller.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
package nodepool
import (
"bytes"
"compress/gzip"
"context"
"encoding/base64"
"encoding/json"
"fmt"
"hash/fnv"
"sort"
"strconv"
"strings"
"time"
ignitionapi "github.com/coreos/ignition/v2/config/v3_2/types"
"github.com/go-logr/logr"
"github.com/google/uuid"
configv1 "github.com/openshift/api/config/v1"
"github.com/openshift/api/operator/v1alpha1"
agentv1 "github.com/openshift/cluster-api-provider-agent/api/v1alpha1"
api "github.com/openshift/hypershift/api"
hyperv1 "github.com/openshift/hypershift/api/v1alpha1"
"github.com/openshift/hypershift/hypershift-operator/controllers/manifests"
"github.com/openshift/hypershift/hypershift-operator/controllers/manifests/ignitionserver"
hyperutil "github.com/openshift/hypershift/hypershift-operator/controllers/util"
"github.com/openshift/hypershift/support/releaseinfo"
"github.com/openshift/hypershift/support/upsert"
mcfgv1 "github.com/openshift/hypershift/thirdparty/machineconfigoperator/pkg/apis/machineconfiguration.openshift.io/v1"
"github.com/pkg/errors"
corev1 "k8s.io/api/core/v1"
apierrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/runtime/schema"
serializer "k8s.io/apimachinery/pkg/runtime/serializer/json"
utilerrors "k8s.io/apimachinery/pkg/util/errors"
"k8s.io/apimachinery/pkg/util/intstr"
"k8s.io/client-go/tools/record"
"k8s.io/client-go/util/workqueue"
k8sutilspointer "k8s.io/utils/pointer"
capiaws "sigs.k8s.io/cluster-api-provider-aws/api/v1beta1"
capiazure "sigs.k8s.io/cluster-api-provider-azure/api/v1beta1"
capikubevirt "sigs.k8s.io/cluster-api-provider-kubevirt/api/v1alpha1"
capiv1 "sigs.k8s.io/cluster-api/api/v1beta1"
"sigs.k8s.io/cluster-api/util"
"sigs.k8s.io/cluster-api/util/patch"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/client/apiutil"
"sigs.k8s.io/controller-runtime/pkg/controller"
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
"sigs.k8s.io/controller-runtime/pkg/handler"
"sigs.k8s.io/controller-runtime/pkg/reconcile"
"sigs.k8s.io/controller-runtime/pkg/source"
)
const (
finalizer = "hypershift.openshift.io/finalizer"
autoscalerMaxAnnotation = "cluster.x-k8s.io/cluster-api-autoscaler-node-group-max-size"
autoscalerMinAnnotation = "cluster.x-k8s.io/cluster-api-autoscaler-node-group-min-size"
nodePoolAnnotation = "hypershift.openshift.io/nodePool"
nodePoolAnnotationCurrentConfig = "hypershift.openshift.io/nodePoolCurrentConfig"
nodePoolAnnotationCurrentConfigVersion = "hypershift.openshift.io/nodePoolCurrentConfigVersion"
nodePoolAnnotationPlatformMachineTemplate = "hypershift.openshift.io/nodePoolPlatformMachineTemplate"
nodePoolCoreIgnitionConfigLabel = "hypershift.openshift.io/core-ignition-config"
TokenSecretTokenGenerationTime = "hypershift.openshift.io/last-token-generation-time"
TokenSecretReleaseKey = "release"
TokenSecretTokenKey = "token"
TokenSecretConfigKey = "config"
TokenSecretAnnotation = "hypershift.openshift.io/ignition-config"
)
type NodePoolReconciler struct {
client.Client
recorder record.EventRecorder
ReleaseProvider releaseinfo.Provider
upsert.CreateOrUpdateProvider
}
func (r *NodePoolReconciler) SetupWithManager(mgr ctrl.Manager) error {
_, err := ctrl.NewControllerManagedBy(mgr).
For(&hyperv1.NodePool{}).
// We want to reconcile when the HostedCluster IgnitionEndpoint is available.
Watches(&source.Kind{Type: &hyperv1.HostedCluster{}}, handler.EnqueueRequestsFromMapFunc(r.enqueueNodePoolsForHostedCluster)).
Watches(&source.Kind{Type: &capiv1.MachineDeployment{}}, handler.EnqueueRequestsFromMapFunc(enqueueParentNodePool)).
Watches(&source.Kind{Type: &capiaws.AWSMachineTemplate{}}, handler.EnqueueRequestsFromMapFunc(enqueueParentNodePool)).
Watches(&source.Kind{Type: &agentv1.AgentMachineTemplate{}}, handler.EnqueueRequestsFromMapFunc(enqueueParentNodePool)).
Watches(&source.Kind{Type: &capiazure.AzureMachineTemplate{}}, handler.EnqueueRequestsFromMapFunc(enqueueParentNodePool)).
// We want to reconcile when the user data Secret or the token Secret is unexpectedly changed out of band.
Watches(&source.Kind{Type: &corev1.Secret{}}, handler.EnqueueRequestsFromMapFunc(enqueueParentNodePool)).
// We want to reconcile when the ConfigMaps referenced by the spec.config and also the core ones change.
Watches(&source.Kind{Type: &corev1.ConfigMap{}}, handler.EnqueueRequestsFromMapFunc(r.enqueueNodePoolsForConfig)).
WithOptions(controller.Options{
RateLimiter: workqueue.NewItemExponentialFailureRateLimiter(1*time.Second, 10*time.Second),
}).
Build(r)
if err != nil {
return errors.Wrap(err, "failed setting up with a controller manager")
}
r.recorder = mgr.GetEventRecorderFor("nodepool-controller")
return nil
}
func (r *NodePoolReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
log := ctrl.LoggerFrom(ctx)
log.Info("Reconciling")
// Fetch the nodePool instance
nodePool := &hyperv1.NodePool{}
err := r.Client.Get(ctx, req.NamespacedName, nodePool)
if err != nil {
if apierrors.IsNotFound(err) {
log.Info("not found", "request", req.String())
return ctrl.Result{}, nil
}
log.Error(err, "error getting nodepool")
return ctrl.Result{}, err
}
hcluster, err := GetHostedClusterByName(ctx, r.Client, nodePool.GetNamespace(), nodePool.Spec.ClusterName)
if err != nil {
return ctrl.Result{}, err
}
controlPlaneNamespace := manifests.HostedControlPlaneNamespace(hcluster.Namespace, hcluster.Name).Name
// If deleted, clean up and return early.
if !nodePool.DeletionTimestamp.IsZero() {
if err := r.delete(ctx, nodePool, hcluster.Spec.InfraID, controlPlaneNamespace); err != nil {
return ctrl.Result{}, fmt.Errorf("failed to delete nodepool: %w", err)
}
// Now we can remove the finalizer.
if controllerutil.ContainsFinalizer(nodePool, finalizer) {
controllerutil.RemoveFinalizer(nodePool, finalizer)
if err := r.Update(ctx, nodePool); err != nil {
return ctrl.Result{}, fmt.Errorf("failed to remove finalizer from nodepool: %w", err)
}
}
log.Info("Deleted nodepool", "name", req.NamespacedName)
return ctrl.Result{}, nil
}
// Ensure the nodePool has a finalizer for cleanup
if !controllerutil.ContainsFinalizer(nodePool, finalizer) {
controllerutil.AddFinalizer(nodePool, finalizer)
if err := r.Update(ctx, nodePool); err != nil {
return ctrl.Result{}, fmt.Errorf("failed to add finalizer to nodepool: %w", err)
}
}
// Initialize the patch helper
patchHelper, err := patch.NewHelper(nodePool, r.Client)
if err != nil {
return ctrl.Result{}, err
}
result, err := r.reconcile(ctx, hcluster, nodePool)
if err != nil {
log.Error(err, "Failed to reconcile NodePool")
r.recorder.Eventf(nodePool, corev1.EventTypeWarning, "ReconcileError", "%v", err)
if err := patchHelper.Patch(ctx, nodePool); err != nil {
log.Error(err, "failed to patch")
return ctrl.Result{}, fmt.Errorf("failed to patch: %w", err)
}
return result, err
}
if err := patchHelper.Patch(ctx, nodePool); err != nil {
log.Error(err, "failed to patch")
return ctrl.Result{}, fmt.Errorf("failed to patch: %w", err)
}
log.Info("Successfully reconciled")
return ctrl.Result{}, nil
}
func (r *NodePoolReconciler) reconcile(ctx context.Context, hcluster *hyperv1.HostedCluster, nodePool *hyperv1.NodePool) (ctrl.Result, error) {
log := ctrl.LoggerFrom(ctx)
// HostedCluster owns NodePools. This should ensure orphan NodePools are garbage collected when cascading deleting.
nodePool.OwnerReferences = util.EnsureOwnerRef(nodePool.OwnerReferences, metav1.OwnerReference{
APIVersion: hyperv1.GroupVersion.String(),
Kind: "HostedCluster",
Name: hcluster.Name,
UID: hcluster.UID,
})
// Get HostedCluster deps.
controlPlaneNamespace := manifests.HostedControlPlaneNamespace(hcluster.Namespace, hcluster.Name).Name
ignEndpoint := hcluster.Status.IgnitionEndpoint
infraID := hcluster.Spec.InfraID
if err := validateInfraID(infraID); err != nil {
// We don't return the error here as reconciling won't solve the input problem.
// An update event will trigger reconciliation.
// TODO (alberto): consider this an condition failure reason when revisiting conditions.
log.Error(err, "Invalid infraID, waiting.")
return reconcile.Result{}, nil
}
// 1. - Reconcile conditions according to current state of the world.
// Validate autoscaling input.
if err := validateAutoscaling(nodePool); err != nil {
setStatusCondition(&nodePool.Status.Conditions, hyperv1.NodePoolCondition{
Type: hyperv1.NodePoolAutoscalingEnabledConditionType,
Status: corev1.ConditionFalse,
Message: err.Error(),
Reason: hyperv1.NodePoolValidationFailedConditionReason,
ObservedGeneration: nodePool.Generation,
})
// We don't return the error here as reconciling won't solve the input problem.
// An update event will trigger reconciliation.
log.Error(err, "validating autoscaling parameters failed")
return reconcile.Result{}, nil
}
if isAutoscalingEnabled(nodePool) {
setStatusCondition(&nodePool.Status.Conditions, hyperv1.NodePoolCondition{
Type: hyperv1.NodePoolAutoscalingEnabledConditionType,
Status: corev1.ConditionTrue,
Reason: hyperv1.NodePoolAsExpectedConditionReason,
Message: fmt.Sprintf("Maximum nodes: %v, Minimum nodes: %v", nodePool.Spec.AutoScaling.Max, nodePool.Spec.AutoScaling.Min),
ObservedGeneration: nodePool.Generation,
})
} else {
setStatusCondition(&nodePool.Status.Conditions, hyperv1.NodePoolCondition{
Type: hyperv1.NodePoolAutoscalingEnabledConditionType,
Status: corev1.ConditionFalse,
Reason: hyperv1.NodePoolAsExpectedConditionReason,
ObservedGeneration: nodePool.Generation,
})
}
// Validate management input.
if err := validateManagement(nodePool); err != nil {
setStatusCondition(&nodePool.Status.Conditions, hyperv1.NodePoolCondition{
Type: hyperv1.NodePoolUpdateManagementEnabledConditionType,
Status: corev1.ConditionFalse,
Message: err.Error(),
Reason: hyperv1.NodePoolValidationFailedConditionReason,
ObservedGeneration: nodePool.Generation,
})
// We don't return the error here as reconciling won't solve the input problem.
// An update event will trigger reconciliation.
log.Error(err, "validating management parameters failed")
return reconcile.Result{}, nil
}
setStatusCondition(&nodePool.Status.Conditions, hyperv1.NodePoolCondition{
Type: hyperv1.NodePoolUpdateManagementEnabledConditionType,
Status: corev1.ConditionTrue,
Reason: hyperv1.NodePoolAsExpectedConditionReason,
ObservedGeneration: nodePool.Generation,
})
// Validate IgnitionEndpoint.
if ignEndpoint == "" {
setStatusCondition(&nodePool.Status.Conditions, hyperv1.NodePoolCondition{
Type: string(hyperv1.IgnitionEndpointAvailable),
Status: corev1.ConditionFalse,
Message: "Ignition endpoint not available, waiting",
Reason: hyperv1.IgnitionEndpointMissingReason,
ObservedGeneration: nodePool.Generation,
})
log.Info("Ignition endpoint not available, waiting")
return reconcile.Result{}, nil
}
removeStatusCondition(&nodePool.Status.Conditions, string(hyperv1.IgnitionEndpointAvailable))
// Validate Ignition CA Secret.
caSecret := ignitionserver.IgnitionCACertSecret(controlPlaneNamespace)
if err := r.Get(ctx, client.ObjectKeyFromObject(caSecret), caSecret); err != nil {
if apierrors.IsNotFound(err) {
setStatusCondition(&nodePool.Status.Conditions, hyperv1.NodePoolCondition{
Type: string(hyperv1.IgnitionEndpointAvailable),
Status: corev1.ConditionFalse,
Reason: hyperv1.IgnitionCACertMissingReason,
Message: "still waiting for ignition CA cert Secret to exist",
ObservedGeneration: nodePool.Generation,
})
log.Info("still waiting for ignition CA cert Secret to exist")
return ctrl.Result{}, nil
} else {
return ctrl.Result{}, fmt.Errorf("failed to get ignition CA Secret: %w", err)
}
}
removeStatusCondition(&nodePool.Status.Conditions, string(hyperv1.IgnitionEndpointAvailable))
caCertBytes, hasCACert := caSecret.Data[corev1.TLSCertKey]
if !hasCACert {
setStatusCondition(&nodePool.Status.Conditions, hyperv1.NodePoolCondition{
Type: string(hyperv1.IgnitionEndpointAvailable),
Status: corev1.ConditionFalse,
Reason: hyperv1.IgnitionCACertMissingReason,
Message: "CA Secret is missing tls.crt key",
ObservedGeneration: nodePool.Generation,
})
log.Info("CA Secret is missing tls.crt key")
return ctrl.Result{}, nil
}
removeStatusCondition(&nodePool.Status.Conditions, hyperv1.IgnitionCACertMissingReason)
// Validate and get releaseImage.
releaseImage, err := r.getReleaseImage(ctx, hcluster, nodePool.Spec.Release.Image)
if err != nil {
setStatusCondition(&nodePool.Status.Conditions, hyperv1.NodePoolCondition{
Type: hyperv1.NodePoolValidReleaseImageConditionType,
Status: corev1.ConditionFalse,
Reason: hyperv1.NodePoolValidationFailedConditionReason,
Message: fmt.Sprintf("Failed to get release image: %v", err.Error()),
ObservedGeneration: nodePool.Generation,
})
return ctrl.Result{}, fmt.Errorf("failed to look up release image metadata: %w", err)
}
setStatusCondition(&nodePool.Status.Conditions, hyperv1.NodePoolCondition{
Type: hyperv1.NodePoolValidReleaseImageConditionType,
Status: corev1.ConditionTrue,
Reason: hyperv1.NodePoolAsExpectedConditionReason,
Message: fmt.Sprintf("Using release image: %s", nodePool.Spec.Release.Image),
ObservedGeneration: nodePool.Generation,
})
// Validate platform specific input.
var ami string
if nodePool.Spec.Platform.Type == hyperv1.AWSPlatform {
if hcluster.Spec.Platform.AWS == nil {
return ctrl.Result{}, fmt.Errorf("the HostedCluster for this NodePool has no .Spec.Platform.AWS, this is unsupported")
}
// TODO: Should the region be included in the NodePool platform information?
ami, err = getAMI(nodePool, hcluster.Spec.Platform.AWS.Region, releaseImage)
if err != nil {
setStatusCondition(&nodePool.Status.Conditions, hyperv1.NodePoolCondition{
Type: hyperv1.NodePoolValidAMIConditionType,
Status: corev1.ConditionFalse,
Reason: hyperv1.NodePoolValidationFailedConditionReason,
Message: fmt.Sprintf("Couldn't discover an AMI for release image %q: %s", nodePool.Spec.Release.Image, err.Error()),
ObservedGeneration: nodePool.Generation,
})
return ctrl.Result{}, fmt.Errorf("couldn't discover an AMI for release image: %w", err)
}
}
setStatusCondition(&nodePool.Status.Conditions, hyperv1.NodePoolCondition{
Type: hyperv1.NodePoolValidAMIConditionType,
Status: corev1.ConditionTrue,
Reason: hyperv1.NodePoolAsExpectedConditionReason,
Message: fmt.Sprintf("Bootstrap AMI is %q", ami),
ObservedGeneration: nodePool.Generation,
})
// Validate config input.
// 3 generic core config resoures: fips, ssh and haproxy.
// TODO (alberto): consider moving the expectedCoreConfigResources check
// into the token Secret controller so we don't block Machine infra creation on this.
expectedCoreConfigResources := 3
if len(hcluster.Spec.ImageContentSources) > 0 {
// additional core config resource created when image content source specified.
expectedCoreConfigResources += 1
}
config, missingConfigs, err := r.getConfig(ctx, nodePool, expectedCoreConfigResources, controlPlaneNamespace)
if err != nil {
setStatusCondition(&nodePool.Status.Conditions, hyperv1.NodePoolCondition{
Type: hyperv1.NodePoolConfigValidConfigConditionType,
Status: corev1.ConditionFalse,
Reason: hyperv1.NodePoolValidationFailedConditionReason,
Message: err.Error(),
ObservedGeneration: nodePool.Generation,
})
return ctrl.Result{}, fmt.Errorf("failed to get config: %w", err)
}
if missingConfigs {
setStatusCondition(&nodePool.Status.Conditions, hyperv1.NodePoolCondition{
Type: hyperv1.NodePoolConfigValidConfigConditionType,
Status: corev1.ConditionFalse,
Reason: hyperv1.NodePoolValidationFailedConditionReason,
Message: "Core ignition config has not been created yet",
ObservedGeneration: nodePool.Generation,
})
// We watch configmaps so we will get an event when these get created
return ctrl.Result{}, nil
}
setStatusCondition(&nodePool.Status.Conditions, hyperv1.NodePoolCondition{
Type: hyperv1.NodePoolConfigValidConfigConditionType,
Status: corev1.ConditionTrue,
Reason: hyperv1.NodePoolAsExpectedConditionReason,
ObservedGeneration: nodePool.Generation,
})
// Check if config needs to be updated.
targetConfigHash := hashStruct(config)
isUpdatingConfig := isUpdatingConfig(nodePool, targetConfigHash)
if isUpdatingConfig {
setStatusCondition(&nodePool.Status.Conditions, hyperv1.NodePoolCondition{
Type: hyperv1.NodePoolUpdatingConfigConditionType,
Status: corev1.ConditionTrue,
Reason: hyperv1.NodePoolAsExpectedConditionReason,
Message: fmt.Sprintf("Updating config in progress. Target config: %s", targetConfigHash),
ObservedGeneration: nodePool.Generation,
})
log.Info("NodePool config is updating",
"current", nodePool.GetAnnotations()[nodePoolAnnotationCurrentConfig],
"target", targetConfigHash)
} else {
removeStatusCondition(&nodePool.Status.Conditions, hyperv1.NodePoolUpdatingConfigConditionType)
}
// Check if version needs to be updated.
targetVersion := releaseImage.Version()
isUpdatingVersion := isUpdatingVersion(nodePool, targetVersion)
if isUpdatingVersion {
setStatusCondition(&nodePool.Status.Conditions, hyperv1.NodePoolCondition{
Type: hyperv1.NodePoolUpdatingVersionConditionType,
Status: corev1.ConditionTrue,
Reason: hyperv1.NodePoolAsExpectedConditionReason,
Message: fmt.Sprintf("Updating version in progress. Target version: %s", targetVersion),
ObservedGeneration: nodePool.Generation,
})
log.Info("NodePool version is updating",
"current", nodePool.Status.Version, "target", targetVersion)
} else {
removeStatusCondition(&nodePool.Status.Conditions, hyperv1.NodePoolUpdatingVersionConditionType)
}
// 2. - Reconcile towards expected state of the world.
targetConfigVersionHash := hashStruct(config + targetVersion)
compressedConfig, err := compress([]byte(config))
if err != nil {
return ctrl.Result{}, fmt.Errorf("failed to compress config: %w", err)
}
// Token Secrets exist for each NodePool config/version and follow "prefixName-configVersionHash" naming convention.
// Ensure old configVersionHash resources are deleted, i.e token Secret and userdata Secret.
if isUpdatingVersion || isUpdatingConfig {
tokenSecret := TokenSecret(controlPlaneNamespace, nodePool.Name, nodePool.GetAnnotations()[nodePoolAnnotationCurrentConfigVersion])
err := r.Get(ctx, client.ObjectKeyFromObject(tokenSecret), tokenSecret)
if err != nil && !apierrors.IsNotFound(err) {
return reconcile.Result{}, fmt.Errorf("failed to get token Secret: %w", err)
}
if err == nil {
if err := setExpirationTimestampOnToken(ctx, r.Client, tokenSecret); err != nil && !apierrors.IsNotFound(err) {
return reconcile.Result{}, fmt.Errorf("failed to set expiration on token Secret: %w", err)
}
}
userDataSecret := IgnitionUserDataSecret(controlPlaneNamespace, nodePool.GetName(), nodePool.GetAnnotations()[nodePoolAnnotationCurrentConfigVersion])
err = r.Get(ctx, client.ObjectKeyFromObject(userDataSecret), userDataSecret)
if err != nil && !apierrors.IsNotFound(err) {
return reconcile.Result{}, fmt.Errorf("failed to get user data Secret: %w", err)
}
if err == nil {
if err := r.Delete(ctx, userDataSecret); err != nil && !apierrors.IsNotFound(err) {
return reconcile.Result{}, fmt.Errorf("failed to delete user data Secret: %w", err)
}
}
}
tokenSecret := TokenSecret(controlPlaneNamespace, nodePool.Name, targetConfigVersionHash)
if result, err := r.CreateOrUpdate(ctx, r.Client, tokenSecret, func() error {
return reconcileTokenSecret(tokenSecret, nodePool, compressedConfig)
}); err != nil {
return ctrl.Result{}, fmt.Errorf("failed to reconcile token Secret: %w", err)
} else {
log.Info("Reconciled token Secret", "result", result)
}
tokenBytes, hasToken := tokenSecret.Data[TokenSecretTokenKey]
if !hasToken {
// This should never happen by design.
return ctrl.Result{}, fmt.Errorf("token secret is missing token key")
}
userDataSecret := IgnitionUserDataSecret(controlPlaneNamespace, nodePool.GetName(), targetConfigVersionHash)
if result, err := r.CreateOrUpdate(ctx, r.Client, userDataSecret, func() error {
return reconcileUserDataSecret(userDataSecret, nodePool, caCertBytes, tokenBytes, ignEndpoint)
}); err != nil {
return ctrl.Result{}, err
} else {
log.Info("Reconciled userData Secret", "result", result)
}
// Store new template hash.
if nodePool.Annotations == nil {
nodePool.Annotations = make(map[string]string)
}
// non automated infrastructure should not have any machine level cluster-api components
if !isAutomatedMachineManagement(nodePool) {
nodePool.Status.Version = targetVersion
if nodePool.Annotations == nil {
nodePool.Annotations = make(map[string]string)
}
if nodePool.Annotations[nodePoolAnnotationCurrentConfig] != targetConfigHash {
log.Info("Config update complete",
"previous", nodePool.Annotations[nodePoolAnnotationCurrentConfig], "new", targetConfigHash)
nodePool.Annotations[nodePoolAnnotationCurrentConfig] = targetConfigHash
}
nodePool.Annotations[nodePoolAnnotationCurrentConfigVersion] = targetConfigVersionHash
return ctrl.Result{}, nil
}
// Reconcile (Platform)MachineTemplate.
template, mutateTemplate, machineTemplateSpecJSON, err := machineTemplateBuilders(hcluster, nodePool, infraID, ami)
if err != nil {
return ctrl.Result{}, err
}
if result, err := r.CreateOrUpdate(ctx, r.Client, template, func() error {
return mutateTemplate(template)
}); err != nil {
return ctrl.Result{}, err
} else {
log.Info("Reconciled Machine template", "result", result)
}
md := machineDeployment(nodePool, infraID, controlPlaneNamespace)
if result, err := controllerutil.CreateOrPatch(ctx, r.Client, md, func() error {
return r.reconcileMachineDeployment(
log,
md, nodePool,
userDataSecret,
template,
infraID,
targetVersion, targetConfigHash, targetConfigVersionHash, machineTemplateSpecJSON)
}); err != nil {
return ctrl.Result{}, fmt.Errorf("failed to reconcile MachineDeployment %q: %w",
client.ObjectKeyFromObject(md).String(), err)
} else {
log.Info("Reconciled MachineDeployment", "result", result)
}
mhc := machineHealthCheck(nodePool, controlPlaneNamespace)
if nodePool.Spec.Management.AutoRepair {
if result, err := ctrl.CreateOrUpdate(ctx, r.Client, mhc, func() error {
return r.reconcileMachineHealthCheck(mhc, nodePool, infraID)
}); err != nil {
return ctrl.Result{}, fmt.Errorf("failed to reconcile MachineHealthCheck %q: %w",
client.ObjectKeyFromObject(mhc).String(), err)
} else {
log.Info("Reconciled MachineHealthCheck", "result", result)
}
setStatusCondition(&nodePool.Status.Conditions, hyperv1.NodePoolCondition{
Type: hyperv1.NodePoolAutorepairEnabledConditionType,
Status: corev1.ConditionTrue,
Reason: hyperv1.NodePoolAsExpectedConditionReason,
ObservedGeneration: nodePool.Generation,
})
} else {
err := r.Get(ctx, client.ObjectKeyFromObject(mhc), mhc)
if err != nil && !apierrors.IsNotFound(err) {
return ctrl.Result{}, err
}
if err == nil {
if err := r.Delete(ctx, mhc); err != nil && !apierrors.IsNotFound(err) {
return ctrl.Result{}, err
}
}
setStatusCondition(&nodePool.Status.Conditions, hyperv1.NodePoolCondition{
Type: hyperv1.NodePoolAutorepairEnabledConditionType,
Status: corev1.ConditionFalse,
Reason: hyperv1.NodePoolAsExpectedConditionReason,
ObservedGeneration: nodePool.Generation,
})
}
return ctrl.Result{}, nil
}
func deleteMachineDeployment(ctx context.Context, c client.Client, md *capiv1.MachineDeployment) error {
err := c.Get(ctx, client.ObjectKeyFromObject(md), md)
if err != nil {
if apierrors.IsNotFound(err) {
return nil
}
return fmt.Errorf("error getting MachineDeployment: %w", err)
}
if md.DeletionTimestamp != nil {
return nil
}
err = c.Delete(ctx, md)
if err != nil {
if apierrors.IsNotFound(err) {
return nil
}
return fmt.Errorf("error deleting MachineDeployment: %w", err)
}
return nil
}
func deleteMachineHealthCheck(ctx context.Context, c client.Client, mhc *capiv1.MachineHealthCheck) error {
err := c.Get(ctx, client.ObjectKeyFromObject(mhc), mhc)
if err != nil {
if apierrors.IsNotFound(err) {
return nil
}
return fmt.Errorf("error getting MachineHealthCheck: %w", err)
}
if mhc.DeletionTimestamp != nil {
return nil
}
err = c.Delete(ctx, mhc)
if err != nil {
if apierrors.IsNotFound(err) {
return nil
}
return fmt.Errorf("error deleting MachineHealthCheck: %w", err)
}
return nil
}
func (r *NodePoolReconciler) delete(ctx context.Context, nodePool *hyperv1.NodePool, infraID, controlPlaneNamespace string) error {
md := machineDeployment(nodePool, infraID, controlPlaneNamespace)
mhc := machineHealthCheck(nodePool, controlPlaneNamespace)
machineTemplates, err := r.listMachineTemplates(nodePool)
if err != nil {
return fmt.Errorf("failed to list MachineTemplates: %w", err)
}
for k := range machineTemplates {
if err := r.Delete(ctx, machineTemplates[k]); err != nil && !apierrors.IsNotFound(err) {
return fmt.Errorf("failed to delete MachineTemplate: %w", err)
}
}
// Delete any secret belonging to this NodePool i.e token Secret and userdata Secret.
secrets, err := r.listSecrets(ctx, nodePool)
if err != nil {
return fmt.Errorf("failed to list secrets: %w", err)
}
for k := range secrets {
if err := r.Delete(ctx, &secrets[k]); err != nil && !apierrors.IsNotFound(err) {
return fmt.Errorf("failed to delete secret: %w", err)
}
}
if err := deleteMachineDeployment(ctx, r.Client, md); err != nil {
return fmt.Errorf("failed to delete MachineDeployment: %w", err)
}
if err := deleteMachineHealthCheck(ctx, r.Client, mhc); err != nil {
return fmt.Errorf("failed to delete MachineHealthCheck: %w", err)
}
return nil
}
func reconcileUserDataSecret(userDataSecret *corev1.Secret, nodePool *hyperv1.NodePool, CA, token []byte, ignEndpoint string) error {
// The token secret controller deletes expired token Secrets.
// When that happens the NodePool controller reconciles and create a new one.
// Then it reconciles the userData Secret with the new generated token.
// Therefore this secret is mutable.
userDataSecret.Immutable = k8sutilspointer.BoolPtr(false)
if userDataSecret.Annotations == nil {
userDataSecret.Annotations = make(map[string]string)
}
userDataSecret.Annotations[nodePoolAnnotation] = client.ObjectKeyFromObject(nodePool).String()
encodedCACert := base64.StdEncoding.EncodeToString(CA)
encodedToken := base64.StdEncoding.EncodeToString(token)
ignConfig := ignConfig(encodedCACert, encodedToken, ignEndpoint)
userDataValue, err := json.Marshal(ignConfig)
if err != nil {
return fmt.Errorf("failed to marshal ignition config: %w", err)
}
userDataSecret.Data = map[string][]byte{
"disableTemplating": []byte(base64.StdEncoding.EncodeToString([]byte("true"))),
"value": userDataValue,
}
return nil
}
func reconcileTokenSecret(tokenSecret *corev1.Secret, nodePool *hyperv1.NodePool, compressedConfig []byte) error {
// The token secret controller updates expired token IDs for token Secrets.
// When that happens the NodePool controller reconciles the userData Secret with the new token ID.
// Therefore this secret is mutable.
tokenSecret.Immutable = k8sutilspointer.BoolPtr(false)
if tokenSecret.Annotations == nil {
tokenSecret.Annotations = make(map[string]string)
}
tokenSecret.Annotations[TokenSecretAnnotation] = "true"
tokenSecret.Annotations[nodePoolAnnotation] = client.ObjectKeyFromObject(nodePool).String()
// active token should never be marked as expired.
delete(tokenSecret.Annotations, hyperv1.IgnitionServerTokenExpirationTimestampAnnotation)
if tokenSecret.Data == nil {
tokenSecret.Data = map[string][]byte{}
tokenSecret.Annotations[TokenSecretTokenGenerationTime] = time.Now().Format(time.RFC3339Nano)
tokenSecret.Data[TokenSecretTokenKey] = []byte(uuid.New().String())
tokenSecret.Data[TokenSecretReleaseKey] = []byte(nodePool.Spec.Release.Image)
tokenSecret.Data[TokenSecretConfigKey] = compressedConfig
}
return nil
}
func (r *NodePoolReconciler) reconcileMachineDeployment(log logr.Logger,
machineDeployment *capiv1.MachineDeployment,
nodePool *hyperv1.NodePool,
userDataSecret *corev1.Secret,
machineTemplateCR client.Object,
CAPIClusterName string,
targetVersion,
targetConfigHash, targetConfigVersionHash, machineTemplateSpecJSON string) error {
// Set annotations and labels
if machineDeployment.GetAnnotations() == nil {
machineDeployment.Annotations = map[string]string{}
}
machineDeployment.Annotations[nodePoolAnnotation] = client.ObjectKeyFromObject(nodePool).String()
if machineDeployment.GetLabels() == nil {
machineDeployment.Labels = map[string]string{}
}
machineDeployment.Labels[capiv1.ClusterLabelName] = CAPIClusterName
resourcesName := generateName(CAPIClusterName, nodePool.Spec.ClusterName, nodePool.GetName())
machineDeployment.Spec.MinReadySeconds = k8sutilspointer.Int32Ptr(int32(0))
gvk, err := apiutil.GVKForObject(machineTemplateCR, api.Scheme)
if err != nil {
return err
}
// Set selector and template
machineDeployment.Spec.ClusterName = CAPIClusterName
if machineDeployment.Spec.Selector.MatchLabels == nil {
machineDeployment.Spec.Selector.MatchLabels = map[string]string{}
}
machineDeployment.Spec.Selector.MatchLabels[resourcesName] = resourcesName
machineDeployment.Spec.Template = capiv1.MachineTemplateSpec{
ObjectMeta: capiv1.ObjectMeta{
Labels: map[string]string{
resourcesName: resourcesName,
capiv1.ClusterLabelName: CAPIClusterName,
},
Annotations: map[string]string{
// TODO (alberto): Use conditions to signal an in progress rolling upgrade
// similar to what we do with nodePoolAnnotationCurrentConfig
nodePoolAnnotationPlatformMachineTemplate: machineTemplateSpecJSON, // This will trigger a deployment rolling upgrade when its value changes.
},
},
Spec: capiv1.MachineSpec{
ClusterName: CAPIClusterName,
Bootstrap: capiv1.Bootstrap{
// Keep current user data for later check.
DataSecretName: machineDeployment.Spec.Template.Spec.Bootstrap.DataSecretName,
},
InfrastructureRef: corev1.ObjectReference{
Kind: gvk.Kind,
APIVersion: gvk.GroupVersion().String(),
Namespace: machineTemplateCR.GetNamespace(),
Name: machineTemplateCR.GetName(),
},
// Keep current version for later check.
Version: machineDeployment.Spec.Template.Spec.Version,
NodeDrainTimeout: nodePool.Spec.NodeDrainTimeout,
},
}
// Set strategy
machineDeployment.Spec.Strategy = &capiv1.MachineDeploymentStrategy{}
machineDeployment.Spec.Strategy.Type = capiv1.MachineDeploymentStrategyType(nodePool.Spec.Management.Replace.Strategy)
if nodePool.Spec.Management.Replace.RollingUpdate != nil {
machineDeployment.Spec.Strategy.RollingUpdate = &capiv1.MachineRollingUpdateDeployment{
MaxUnavailable: nodePool.Spec.Management.Replace.RollingUpdate.MaxUnavailable,
MaxSurge: nodePool.Spec.Management.Replace.RollingUpdate.MaxSurge,
}
}
// Propagate version and userData Secret to the machineDeployment.
if userDataSecret.Name != k8sutilspointer.StringPtrDerefOr(machineDeployment.Spec.Template.Spec.Bootstrap.DataSecretName, "") {
log.Info("New user data Secret has been generated",
"current", machineDeployment.Spec.Template.Spec.Bootstrap.DataSecretName,
"target", userDataSecret.Name)
if targetVersion != k8sutilspointer.StringPtrDerefOr(machineDeployment.Spec.Template.Spec.Version, "") {
log.Info("Starting version update: Propagating new version to the MachineDeployment",
"releaseImage", nodePool.Spec.Release.Image, "target", targetVersion)
}
if targetConfigHash != nodePool.Annotations[nodePoolAnnotationCurrentConfig] {
log.Info("Starting config update: Propagating new config to the MachineDeployment",
"current", nodePool.Annotations[nodePoolAnnotationCurrentConfig], "target", targetConfigHash)
}
machineDeployment.Spec.Template.Spec.Version = &targetVersion
machineDeployment.Spec.Template.Spec.Bootstrap.DataSecretName = k8sutilspointer.StringPtr(userDataSecret.Name)
// We return early here during a version/config update to persist the resource with new user data Secret,
// so in the next reconciling loop we get a new MachineDeployment.Generation
// and we can do a legit MachineDeploymentComplete/MachineDeployment.Status.ObservedGeneration check.
// Before persisting, if the NodePool is brand new we want to make sure the replica number is set so the machineDeployment controller
// does not panic.
if machineDeployment.Spec.Replicas == nil {
machineDeployment.Spec.Replicas = k8sutilspointer.Int32Ptr(k8sutilspointer.Int32PtrDerefOr(nodePool.Spec.NodeCount, 0))
}
return nil
}
// If the MachineDeployment is no processing we know
// is at the expected version (spec.version) and config (userData Secret) so we reconcile status and annotation.
if MachineDeploymentComplete(machineDeployment) {
if nodePool.Status.Version != targetVersion {
log.Info("Version update complete",
"previous", nodePool.Status.Version, "new", targetVersion)
nodePool.Status.Version = targetVersion
}
if nodePool.Annotations[nodePoolAnnotationCurrentConfig] != targetConfigHash {
log.Info("Config update complete",
"previous", nodePool.Annotations[nodePoolAnnotationCurrentConfig], "new", targetConfigHash)
nodePool.Annotations[nodePoolAnnotationCurrentConfig] = targetConfigHash
}
nodePool.Annotations[nodePoolAnnotationCurrentConfigVersion] = targetConfigVersionHash
}
setMachineDeploymentReplicas(nodePool, machineDeployment)
// Bubble up AvailableReplicas and Ready condition from MachineDeployment.
nodePool.Status.NodeCount = machineDeployment.Status.AvailableReplicas
for _, c := range machineDeployment.Status.Conditions {
// This condition should aggregate and summarise readiness from underlying MachineSets and Machines
// https://github.com/kubernetes-sigs/cluster-api/issues/3486.
if c.Type == capiv1.ReadyCondition {
// this is so api server does not complain
// invalid value: \"\": status.conditions.reason in body should be at least 1 chars long"
reason := hyperv1.NodePoolAsExpectedConditionReason
if c.Reason != "" {
reason = c.Reason
}
setStatusCondition(&nodePool.Status.Conditions, hyperv1.NodePoolCondition{
Type: hyperv1.NodePoolReadyConditionType,
Status: c.Status,
ObservedGeneration: nodePool.Generation,
Message: c.Message,
Reason: reason,
})
break
}
}
return nil
}
func (r *NodePoolReconciler) reconcileMachineHealthCheck(mhc *capiv1.MachineHealthCheck,
nodePool *hyperv1.NodePool,
CAPIClusterName string) error {
// Opinionated spec based on
// https://github.com/openshift/managed-cluster-config/blob/14d4255ec75dc263ffd3d897dfccc725cb2b7072/deploy/osd-machine-api/011-machine-api.srep-worker-healthcheck.MachineHealthCheck.yaml
// TODO (alberto): possibly expose this config at the nodePool API.
maxUnhealthy := intstr.FromInt(2)
resourcesName := generateName(CAPIClusterName, nodePool.Spec.ClusterName, nodePool.GetName())
mhc.Spec = capiv1.MachineHealthCheckSpec{
ClusterName: CAPIClusterName,
Selector: metav1.LabelSelector{
MatchLabels: map[string]string{
resourcesName: resourcesName,
},
},
UnhealthyConditions: []capiv1.UnhealthyCondition{
{
Type: corev1.NodeReady,
Status: corev1.ConditionFalse,
Timeout: metav1.Duration{
Duration: 8 * time.Minute,
},
},
{
Type: corev1.NodeReady,
Status: corev1.ConditionUnknown,
Timeout: metav1.Duration{
Duration: 8 * time.Minute,
},
},
},
MaxUnhealthy: &maxUnhealthy,
NodeStartupTimeout: &metav1.Duration{
Duration: 10 * time.Minute,
},
}
return nil
}
// setMachineDeploymentReplicas sets wanted replicas:
// If autoscaling is enabled we reconcile min/max annotations and leave replicas untouched.
func setMachineDeploymentReplicas(nodePool *hyperv1.NodePool, machineDeployment *capiv1.MachineDeployment) {
if machineDeployment.Annotations == nil {
machineDeployment.Annotations = make(map[string]string)
}
if isAutoscalingEnabled(nodePool) {
if k8sutilspointer.Int32PtrDerefOr(machineDeployment.Spec.Replicas, 0) == 0 {
// if autoscaling is enabled and the machineDeployment does not exist yet or it has 0 replicas
// we set it to 1 replica as the autoscaler does not support scaling from zero yet.
machineDeployment.Spec.Replicas = k8sutilspointer.Int32Ptr(int32(1))
}
machineDeployment.Annotations[autoscalerMaxAnnotation] = strconv.Itoa(int(nodePool.Spec.AutoScaling.Max))
machineDeployment.Annotations[autoscalerMinAnnotation] = strconv.Itoa(int(nodePool.Spec.AutoScaling.Min))
}
// If autoscaling is NOT enabled we reset min/max annotations and reconcile replicas.
if !isAutoscalingEnabled(nodePool) {
machineDeployment.Annotations[autoscalerMaxAnnotation] = "0"
machineDeployment.Annotations[autoscalerMinAnnotation] = "0"
machineDeployment.Spec.Replicas = k8sutilspointer.Int32Ptr(k8sutilspointer.Int32PtrDerefOr(nodePool.Spec.NodeCount, 0))
}
}
func getAMI(nodePool *hyperv1.NodePool, region string, releaseImage *releaseinfo.ReleaseImage) (string, error) {
if nodePool.Spec.Platform.AWS.AMI != "" {
return nodePool.Spec.Platform.AWS.AMI, nil
}
return defaultNodePoolAMI(region, releaseImage)
}
func ignConfig(encodedCACert, encodedToken, endpoint string) ignitionapi.Config {
return ignitionapi.Config{
Ignition: ignitionapi.Ignition{
Version: "3.2.0",
Security: ignitionapi.Security{
TLS: ignitionapi.TLS{
CertificateAuthorities: []ignitionapi.Resource{
{
Source: k8sutilspointer.StringPtr(fmt.Sprintf("data:text/plain;base64,%s", encodedCACert)),
},
},
},
},
Config: ignitionapi.IgnitionConfig{
Merge: []ignitionapi.Resource{
{
Source: k8sutilspointer.StringPtr(fmt.Sprintf("https://%s/ignition", endpoint)),
HTTPHeaders: []ignitionapi.HTTPHeader{
{
Name: "Authorization",
Value: k8sutilspointer.StringPtr(fmt.Sprintf("Bearer %s", encodedToken)),
},
},
},
},
},
},
}
}
func (r *NodePoolReconciler) getConfig(ctx context.Context, nodePool *hyperv1.NodePool, expectedCoreConfigResources int, controlPlaneResource string) (configsRaw string, missingConfigs bool, err error) {
var configs []corev1.ConfigMap
var allConfigPlainText []string
var errors []error
coreConfigMapList := &corev1.ConfigMapList{}
if err := r.List(ctx, coreConfigMapList, client.MatchingLabels{
nodePoolCoreIgnitionConfigLabel: "true",
}, client.InNamespace(controlPlaneResource)); err != nil {
errors = append(errors, err)
}
if len(coreConfigMapList.Items) != expectedCoreConfigResources {
missingConfigs = true
}
configs = coreConfigMapList.Items
for _, config := range nodePool.Spec.Config {
configConfigMap := &corev1.ConfigMap{
ObjectMeta: metav1.ObjectMeta{
Name: config.Name,
Namespace: nodePool.Namespace,
},
}
if err := r.Get(ctx, client.ObjectKeyFromObject(configConfigMap), configConfigMap); err != nil {
errors = append(errors, err)
continue
}
configs = append(configs, *configConfigMap)
}
for _, config := range configs {
manifest := config.Data[TokenSecretConfigKey]
if err := validateConfigManifest([]byte(manifest)); err != nil {
errors = append(errors, fmt.Errorf("configmap %q failed validation: %w", config.Name, err))
continue
}
allConfigPlainText = append(allConfigPlainText, manifest)
}
// These configs are the input to a hash func whose output is used as part of the name of the user-data secret,
// so our output must be deterministic.
sort.Strings(allConfigPlainText)
return strings.Join(allConfigPlainText, "\n---\n"), missingConfigs, utilerrors.NewAggregate(errors)
}
// validateManagement does additional backend validation. API validation/default should
// prevent this from ever fail.
func validateManagement(nodePool *hyperv1.NodePool) error {
// Only upgradeType "Replace" is supported atm.
if nodePool.Spec.Management.UpgradeType != hyperv1.UpgradeTypeReplace ||
nodePool.Spec.Management.Replace == nil {
return fmt.Errorf("this is unsupported. %q upgrade type and a strategy: %q or %q are required",
hyperv1.UpgradeTypeReplace, hyperv1.UpgradeStrategyRollingUpdate, hyperv1.UpgradeStrategyOnDelete)