-
Notifications
You must be signed in to change notification settings - Fork 51
/
validators.go
450 lines (363 loc) · 15.3 KB
/
validators.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
package validate
import (
"encoding/base64"
"fmt"
"net"
"github.com/openshift/openshift-azure/pkg/api"
)
func validateContainerService(c *api.OpenShiftManagedCluster, externalOnly bool) (errs []error) {
if c == nil {
errs = append(errs, fmt.Errorf("openShiftManagedCluster cannot be nil"))
return
}
errs = append(errs, validateProperties(&c.Properties, c.Location, externalOnly)...)
if !isValidClusterName(c.Name) {
errs = append(errs, fmt.Errorf("invalid name %q", c.Name))
}
if !isValidLocation(c.Location) {
errs = append(errs, fmt.Errorf("invalid location %q", c.Location))
}
// TODO: we don't currently validate Config
return
}
func validateProperties(p *api.Properties, location string, externalOnly bool) (errs []error) {
if p == nil {
errs = append(errs, fmt.Errorf("properties cannot be nil"))
return
}
switch p.ProvisioningState {
case "",
api.Creating,
api.Updating,
api.AdminUpdating,
api.Failed,
api.Succeeded,
api.Deleting,
api.Migrating,
api.Upgrading:
default:
errs = append(errs, fmt.Errorf("invalid properties.provisioningState %q", p.ProvisioningState))
}
switch p.OpenShiftVersion {
case "v3.11":
default:
errs = append(errs, fmt.Errorf("invalid properties.openShiftVersion %q", p.OpenShiftVersion))
}
if !externalOnly {
// TODO: consider ensuring that PublicSubdomain is of the form
// openshift.<random>.<location>.azmosa.io
if !isValidHostname(p.PublicHostname) {
errs = append(errs, fmt.Errorf("invalid properties.publicHostname %q", p.PublicHostname))
}
if !isValidCloudAppHostname(p.FQDN, location) {
errs = append(errs, fmt.Errorf("invalid properties.fqdn %q", p.FQDN))
}
if p.FQDN == p.PublicHostname {
errs = append(errs, fmt.Errorf("invalid properties.fqdn %q: must differ from properties.publicHostname", p.FQDN))
}
}
errs = append(errs, validateNetworkProfile("properties.networkProfile", &p.NetworkProfile)...)
errs = append(errs, validateRouterProfiles("properties.routerProfiles", p.RouterProfiles, location, externalOnly)...)
errs = append(errs, validateAgentPoolProfiles(p.AgentPoolProfiles, &p.NetworkProfile)...)
errs = append(errs, validateAuthProfile("properties.authProfile", &p.AuthProfile)...)
errs = append(errs, validateMonitorProfile("properties.monitorProfile", &p.MonitorProfile, externalOnly)...)
if !externalOnly {
errs = append(errs, validateServicePrincipalProfile("properties.masterServicePrincipalProfile", &p.MasterServicePrincipalProfile)...)
errs = append(errs, validateServicePrincipalProfile("properties.workerServicePrincipalProfile", &p.WorkerServicePrincipalProfile)...)
errs = append(errs, validateAzProfile("properties.azProfile", &p.AzProfile)...)
errs = append(errs, validateCertProfile("properties.apiCertProfile", &p.APICertProfile)...)
}
return
}
func validateNetworkProfile(path string, np *api.NetworkProfile) (errs []error) {
if np == nil {
errs = append(errs, fmt.Errorf("%s cannot be nil", path))
return
}
if !isValidIPV4CIDR(np.VnetCIDR) {
errs = append(errs, fmt.Errorf("invalid %s.vnetCidr %q", path, np.VnetCIDR))
return
}
// We dont enforce ManagementSubnetCIDR, but if it set - require valid value
if np.ManagementSubnetCIDR != nil {
if !isValidIPV4CIDR(*np.ManagementSubnetCIDR) {
errs = append(errs, fmt.Errorf("invalid %s.managementSubnetCIDR %q", path, *np.ManagementSubnetCIDR))
return
}
_, managementSubnet, _ := net.ParseCIDR(*np.ManagementSubnetCIDR)
_, vnet, _ := net.ParseCIDR(np.VnetCIDR)
if !vnetContainsSubnet(vnet, managementSubnet) {
errs = append(errs, fmt.Errorf("invalid %s.managementSubnetCIDR %q: not contained in properties.networkProfile.vnetCidr %q", path, *np.ManagementSubnetCIDR, np.VnetCIDR))
}
}
if np.VnetID != "" && !rxVNetID.MatchString(np.VnetID) {
errs = append(errs, fmt.Errorf("invalid %s.vnetId %q", path, np.VnetID))
}
if np.PeerVnetID != nil && !rxVNetID.MatchString(*np.PeerVnetID) {
errs = append(errs, fmt.Errorf("invalid %s.peerVnetId %q", path, *np.PeerVnetID))
}
return
}
func validateMonitorProfile(path string, mp *api.MonitorProfile, externalOnly bool) (errs []error) {
if mp.WorkspaceResourceID != "" && !rxWorkspaceResourceID.MatchString(mp.WorkspaceResourceID) {
errs = append(errs, fmt.Errorf("invalid %s.workspaceResourceId %q", path, mp.WorkspaceResourceID))
}
if mp.Enabled {
if mp.WorkspaceResourceID == "" {
errs = append(errs, fmt.Errorf("%s.workspaceResourceID cannot be empty if %[1]s.enabled = true", path))
}
}
if !externalOnly {
if mp.WorkspaceID != "" && !isValidUUID(mp.WorkspaceID) {
errs = append(errs, fmt.Errorf("invalid %s.workspaceId %q", path, mp.WorkspaceID))
}
if len(mp.WorkspaceKey) > 256 {
errs = append(errs, fmt.Errorf("invalid %s.workspaceKey", path))
} else if _, err := base64.StdEncoding.DecodeString(mp.WorkspaceKey); err != nil {
errs = append(errs, fmt.Errorf("invalid %s.workspaceKey", path))
}
if mp.Enabled {
if mp.WorkspaceID == "" {
errs = append(errs, fmt.Errorf("%s.workspaceID cannot be empty if %[1]s.enabled = true", path))
}
if mp.WorkspaceKey == "" {
errs = append(errs, fmt.Errorf("%s.workspaceKey cannot be empty if %[1]s.enabled = true", path))
}
}
}
return
}
func validateRouterProfiles(path string, rps []api.RouterProfile, location string, externalOnly bool) (errs []error) {
rpmap := map[string]api.RouterProfile{}
for _, rp := range rps {
if _, found := validRouterProfileNames[rp.Name]; !found {
errs = append(errs, fmt.Errorf("invalid %s[%q]", path, rp.Name))
}
if _, found := rpmap[rp.Name]; found {
errs = append(errs, fmt.Errorf("duplicate %s[%q]", path, rp.Name))
}
rpmap[rp.Name] = rp
errs = append(errs, validateRouterProfile(fmt.Sprintf("%s[%q]", path, rp.Name), &rp, location, externalOnly)...)
}
// a bit questionable: seems that we allow a user to PUT empty
// RouterProfiles on cluster creation. We allow this on the first
// validation pass (externalOnly set), then the RP apparently defaults in a
// RouterProfile before validating a second time without externalOnly set.
if !externalOnly {
for name := range validRouterProfileNames {
if _, found := rpmap[name]; !found {
errs = append(errs, fmt.Errorf("invalid %s[%q]", path, name))
}
}
}
return
}
func validateRouterProfile(path string, rp *api.RouterProfile, location string, externalOnly bool) (errs []error) {
if rp == nil {
errs = append(errs, fmt.Errorf("%s cannot be nil", path))
return
}
if !rxRouterProfileName.MatchString(rp.Name) {
errs = append(errs, fmt.Errorf("invalid %s", path))
}
if !externalOnly {
// TODO: consider ensuring that PublicSubdomain is of the form
// apps.<random>.<location>.azmosa.io
if !isValidHostname(rp.PublicSubdomain) {
errs = append(errs, fmt.Errorf("invalid %s.publicSubdomain %q", path, rp.PublicSubdomain))
}
if !isValidCloudAppHostname(rp.FQDN, location) {
errs = append(errs, fmt.Errorf("invalid %s.fqdn %q", path, rp.FQDN))
}
if rp.FQDN == rp.PublicSubdomain {
errs = append(errs, fmt.Errorf("invalid %s.fqdn %q: must differ from %[1]s.publicSubdomain", path, rp.FQDN))
}
errs = append(errs, validateCertProfile(path+".routerCertProfile", &rp.RouterCertProfile)...)
}
return
}
func validateCertProfile(path string, cp *api.CertProfile) (errs []error) {
if cp == nil {
errs = append(errs, fmt.Errorf("%s cannot be nil", path))
return
}
if !rxKeyVaultSecretURL.MatchString(cp.KeyVaultSecretURL) {
errs = append(errs, fmt.Errorf("invalid %s.keyVaultSecretURL %q", path, cp.KeyVaultSecretURL))
}
return
}
func validateAgentPoolProfiles(apps []api.AgentPoolProfile, np *api.NetworkProfile) (errs []error) {
appmap := map[api.AgentPoolProfileRole]api.AgentPoolProfile{}
for i, app := range apps {
if _, found := validAgentPoolProfileRoles[app.Role]; !found {
errs = append(errs, fmt.Errorf("invalid role %q in properties.agentPoolProfiles[%q]", app.Role, app.Name))
}
if _, found := appmap[app.Role]; found {
errs = append(errs, fmt.Errorf("duplicate role %q in properties.agentPoolProfiles[%q]", app.Role, app.Name))
}
appmap[app.Role] = app
if i > 0 && app.SubnetCIDR != apps[i-1].SubnetCIDR { // TODO: in the future, test that these are disjoint
errs = append(errs, fmt.Errorf("invalid properties.agentPoolProfiles.subnetCidr %q: all subnetCidrs must match", app.SubnetCIDR))
}
errs = append(errs, validateAgentPoolProfile(&app, np)...)
}
for role := range validAgentPoolProfileRoles {
if _, found := appmap[role]; !found {
errs = append(errs, fmt.Errorf("missing role %q in properties.agentPoolProfiles", role))
}
}
if appmap[api.AgentPoolProfileRoleMaster].VMSize != appmap[api.AgentPoolProfileRoleInfra].VMSize {
errs = append(errs, fmt.Errorf("invalid properties.agentPoolProfiles.vmSize %q: master and infra vmSizes must match", appmap[api.AgentPoolProfileRoleInfra].VMSize))
}
return
}
func validateAgentPoolProfile(app *api.AgentPoolProfile, np *api.NetworkProfile) (errs []error) {
if app == nil {
errs = append(errs, fmt.Errorf("agentPoolProfile cannot be nil"))
return
}
// we can disregard any error below because we are already going to fail
// validation if VnetCIDR does not parse correctly.
_, vnet, _ := net.ParseCIDR(np.VnetCIDR)
switch app.Role {
case api.AgentPoolProfileRoleCompute:
switch app.Name {
case string(api.AgentPoolProfileRoleMaster), string(api.AgentPoolProfileRoleInfra):
errs = append(errs, fmt.Errorf("invalid properties.agentPoolProfiles[%q]", app.Name))
}
if !rxAgentPoolProfileName.MatchString(app.Name) {
errs = append(errs, fmt.Errorf("invalid properties.agentPoolProfiles[%q].name %q", app.Name, app.Name))
}
if app.Count < 1 || app.Count > 30 {
errs = append(errs, fmt.Errorf("invalid properties.agentPoolProfiles[%q].count %d", app.Name, app.Count))
}
case api.AgentPoolProfileRoleInfra:
if app.Name != string(app.Role) {
errs = append(errs, fmt.Errorf("invalid properties.agentPoolProfiles[%q]", app.Name))
}
if app.Count != 3 {
errs = append(errs, fmt.Errorf("invalid properties.agentPoolProfiles[%q].count %d", app.Name, app.Count))
}
case api.AgentPoolProfileRoleMaster:
if app.Name != string(app.Role) {
errs = append(errs, fmt.Errorf("invalid properties.agentPoolProfiles[%q]", app.Name))
}
if app.Count != 3 {
errs = append(errs, fmt.Errorf("invalid properties.masterPoolProfile.count %d", app.Count))
}
}
// VMSize is checked by the caller using validateVMSize as it depends on
// runningUnderTest.
if !isValidIPV4CIDR(app.SubnetCIDR) {
errs = append(errs, fmt.Errorf("invalid properties.agentPoolProfiles[%q].subnetCidr %q", app.Name, app.SubnetCIDR))
}
_, subnet, _ := net.ParseCIDR(app.SubnetCIDR)
if vnet != nil && subnet != nil {
// we are already going to fail validation if one of these is nil.
if !vnetContainsSubnet(vnet, subnet) {
errs = append(errs, fmt.Errorf("invalid properties.agentPoolProfiles[%q].subnetCidr %q: not contained in properties.networkProfile.vnetCidr %q", app.Name, app.SubnetCIDR, vnet.String()))
}
if vnetContainsSubnet(serviceNetworkCIDR, subnet) || vnetContainsSubnet(subnet, serviceNetworkCIDR) {
errs = append(errs, fmt.Errorf("invalid properties.agentPoolProfiles[%q].subnetCidr %q: overlaps with service network %q", app.Name, app.SubnetCIDR, serviceNetworkCIDR.String()))
}
if vnetContainsSubnet(clusterNetworkCIDR, subnet) || vnetContainsSubnet(subnet, clusterNetworkCIDR) {
errs = append(errs, fmt.Errorf("invalid properties.agentPoolProfiles[%q].subnetCidr %q: overlaps with cluster network %q", app.Name, app.SubnetCIDR, clusterNetworkCIDR.String()))
}
if np.ManagementSubnetCIDR != nil && isValidIPV4CIDR(np.VnetCIDR) && isValidIPV4CIDR(*np.ManagementSubnetCIDR) {
_, managementSubnet, _ := net.ParseCIDR(*np.ManagementSubnetCIDR)
if vnetContainsSubnet(managementSubnet, subnet) || vnetContainsSubnet(subnet, managementSubnet) {
errs = append(errs, fmt.Errorf("invalid properties.agentPoolProfiles[%q].subnetCidr %q: overlaps with cluster managementSubnetCidr %q", app.Name, app.SubnetCIDR, managementSubnet.String()))
}
}
}
switch app.OSType {
case api.OSTypeLinux:
default:
errs = append(errs, fmt.Errorf("invalid properties.agentPoolProfiles[%q].osType %q", app.Name, app.OSType))
}
return
}
func validateAuthProfile(path string, ap *api.AuthProfile) (errs []error) {
if ap == nil {
errs = append(errs, fmt.Errorf("%s cannot be nil", path))
return
}
if len(ap.IdentityProviders) != 1 {
errs = append(errs, fmt.Errorf("invalid %s.identityProviders length", path))
}
//check supported identity providers
for _, ip := range ap.IdentityProviders {
if ip.Name != "Azure AD" {
errs = append(errs, fmt.Errorf("invalid %s.identityProviders[%q]", path, ip.Name))
}
switch provider := ip.Provider.(type) {
case (*api.AADIdentityProvider):
if provider.Kind != "AADIdentityProvider" {
errs = append(errs, fmt.Errorf("invalid %s.identityProviders[%q].kind %q", path, ip.Name, provider.Kind))
}
if !isValidUUID(provider.ClientID) {
errs = append(errs, fmt.Errorf("invalid %s.identityProviders[%q].clientId %q", path, ip.Name, provider.ClientID))
}
if provider.Secret == "" {
errs = append(errs, fmt.Errorf("invalid %s.identityProviders[%q].secret %q", path, ip.Name, "<hidden>"))
}
if !isValidUUID(provider.TenantID) {
errs = append(errs, fmt.Errorf("invalid %s.identityProviders[%q].tenantId %q", path, ip.Name, provider.TenantID))
}
if provider.CustomerAdminGroupID != nil && !isValidUUID(*provider.CustomerAdminGroupID) {
errs = append(errs, fmt.Errorf("invalid %s.identityProviders[%q].customerAdminGroupId %q", path, ip.Name, *provider.CustomerAdminGroupID))
}
}
}
return
}
func validateServicePrincipalProfile(path string, p *api.ServicePrincipalProfile) (errs []error) {
if p == nil {
errs = append(errs, fmt.Errorf("%s cannot be nil", path))
return
}
if !isValidUUID(p.ClientID) {
errs = append(errs, fmt.Errorf("invalid %s.clientID %q", path, p.ClientID))
}
if p.Secret == "" {
errs = append(errs, fmt.Errorf("invalid %s.secret %q", path, p.Secret))
}
return
}
func validateAzProfile(path string, a *api.AzProfile) (errs []error) {
if a == nil {
errs = append(errs, fmt.Errorf("%s cannot be nil", path))
return
}
if !isValidUUID(a.TenantID) {
errs = append(errs, fmt.Errorf("invalid %s.tenantId %q", path, a.TenantID))
}
if !isValidUUID(a.SubscriptionID) {
errs = append(errs, fmt.Errorf("invalid %s.subscriptionId %q", path, a.SubscriptionID))
}
if !rxResourceGroupName.MatchString(a.ResourceGroup) {
errs = append(errs, fmt.Errorf("invalid %s.resourceGroup %q", path, a.ResourceGroup))
}
return
}
func validateVMSize(app *api.AgentPoolProfile, runningUnderTest bool) (errs []error) {
if app == nil {
errs = append(errs, fmt.Errorf("agentPoolProfile cannot be nil"))
return
}
switch app.Role {
case api.AgentPoolProfileRoleMaster:
if !isValidMasterAndInfraVMSize(app.VMSize, runningUnderTest) {
errs = append(errs, fmt.Errorf("invalid properties.masterPoolProfile.vmSize %q", app.VMSize))
}
case api.AgentPoolProfileRoleInfra:
if !isValidMasterAndInfraVMSize(app.VMSize, runningUnderTest) {
errs = append(errs, fmt.Errorf("invalid properties.agentPoolProfiles[%q].vmSize %q", app.Name, app.VMSize))
}
case api.AgentPoolProfileRoleCompute:
if !isValidComputeVMSize(app.VMSize, runningUnderTest) {
errs = append(errs, fmt.Errorf("invalid properties.agentPoolProfiles[%q].vmSize %q", app.Name, app.VMSize))
}
}
return
}