Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator-lib 0.11.0 is not compatible with controller-runtime v0.15.0 #115

Closed
iblancasa opened this issue Jun 8, 2023 · 4 comments
Closed

Comments

@iblancasa
Copy link

Bug Report

What did you do?
While building one operator using operator-lib 0.11.0 and controller-gen 0.15.0, the following build error is thrown:

# github.com/operator-framework/operator-lib/internal/annotation
../../gopath/pkg/mod/github.com/operator-framework/operator-lib@v0.11.0/internal/annotation/filter.go:90:15: cannot use func(evt event.CreateEvent, q workqueue.RateLimitingInterface) {…} (value of type func(evt event.CreateEvent, q workqueue.RateLimitingInterface)) as func(context.Context, event.CreateEvent, workqueue.RateLimitingInterface) value in struct literal
../../gopath/pkg/mod/github.com/operator-framework/operator-lib@v0.11.0/internal/annotation/filter.go:92:24: not enough arguments in call to f.hdlr.Create
	have (event.CreateEvent, workqueue.RateLimitingInterface)
	want (context.Context, event.CreateEvent, workqueue.RateLimitingInterface)
../../gopath/pkg/mod/github.com/operator-framework/operator-lib@v0.11.0/internal/annotation/filter.go:95:15: cannot use func(evt event.UpdateEvent, q workqueue.RateLimitingInterface) {…} (value of type func(evt event.UpdateEvent, q workqueue.RateLimitingInterface)) as func(context.Context, event.UpdateEvent, workqueue.RateLimitingInterface) value in struct literal
../../gopath/pkg/mod/github.com/operator-framework/operator-lib@v0.11.0/internal/annotation/filter.go:97:24: not enough arguments in call to f.hdlr.Update
	have (event.UpdateEvent, workqueue.RateLimitingInterface)
	want (context.Context, event.UpdateEvent, workqueue.RateLimitingInterface)
../../gopath/pkg/mod/github.com/operator-framework/operator-lib@v0.11.0/internal/annotation/filter.go:100:15: cannot use func(evt event.DeleteEvent, q workqueue.RateLimitingInterface) {…} (value of type func(evt event.DeleteEvent, q workqueue.RateLimitingInterface)) as func(context.Context, event.DeleteEvent, workqueue.RateLimitingInterface) value in struct literal
../../gopath/pkg/mod/github.com/operator-framework/operator-lib@v0.11.0/internal/annotation/filter.go:102:24: not enough arguments in call to f.hdlr.Delete
	have (event.DeleteEvent, workqueue.RateLimitingInterface)
	want (context.Context, event.DeleteEvent, workqueue.RateLimitingInterface)
../../gopath/pkg/mod/github.com/operator-framework/operator-lib@v0.11.0/internal/annotation/filter.go:105:16: cannot use func(evt event.GenericEvent, q workqueue.RateLimitingInterface) {…} (value of type func(evt event.GenericEvent, q workqueue.RateLimitingInterface)) as func(context.Context, event.GenericEvent, workqueue.RateLimitingInterface) value in struct literal
../../gopath/pkg/mod/github.com/operator-framework/operator-lib@v0.11.0/internal/annotation/filter.go:107:25: not enough arguments in call to f.hdlr.Generic
	have (event.GenericEvent, workqueue.RateLimitingInterface)
	want (context.Context, event.GenericEvent, workqueue.RateLimitingInterface)

Possible Solution
I think this was solved in #114 but we need one release of the package.

@iblancasa
Copy link
Author

The fixed added in #114 solves the problem. When can we expect a release? Is there anything I can do to help having the release?

@muhammadnmuhammad01
Copy link

Any updates on this? Anything we can do to help with the release?

@skattoju
Copy link

cc: @rashmigottipati (since you did the last merge) can we cut a release ? Not sure if there is something blocking thats preventing us from releasing ?

@iblancasa
Copy link
Author

There was a release on Jan 10th. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants