PR lookup detection in CHANGELOG generation is not working as expected

[rashmigottipati]

Bug Report

Generating the CHANGELOG from the fragments may result in some lines pointing to incorrect PR links.

For the 1.11.0 release, the release notes https://github.com/operator-framework/operator-sdk/releases/tag/v1.11.0 have three additions and changes that have incorrect PR links. Below are the changes that have incorrect PR links:

• (go/v3, ansible/v1, helm/v1) Added containerPort protocol field required for server-side apply in manifests. (bump kb to latest commit and projects to k8s 1.20 #4863)
• (go/v3) Fixed a bug in make test caused by incorrect envtest asset setup. (bump kb to latest commit and projects to k8s 1.20 #4863)
• (go/v3, ansible/v1, helm/v1) Increased resource limits for controller manager. (bump kb to latest commit and projects to k8s 1.20 #4863)

All those three changes reference the PR #4863, however the PR that resulted in those changes is #5117.

In most cases, the PR lookup detection works just fine and as expected. In this particular case, it's possible that the PR lookup is getting confused as #4863 and #5117 begin with the same name and contain similar words, however, the proper resolution would be that the PR lookup algorithm should purely be based on finding the right fragments and linking the PRs appropriately.

[rashmigottipati]

We should also probably add a note to the release documentation for the release PR authors and approvers to do a manual check and make sure that the linked PRs in the release notes PR are all accurate.

[asmacdo]

If we cant get this done by 1.12, lets do a manual audit to make sure the links are correct.
@jberkhahn

[jmrodri]

This hasn't happened in a while. I don't think it's worth keeping open.