Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support intralinks to foreign impl items #234

Open
orium opened this issue Apr 16, 2024 · 0 comments
Open

Support intralinks to foreign impl items #234

orium opened this issue Apr 16, 2024 · 0 comments

Comments

@orium
Copy link
Owner

orium commented Apr 16, 2024

After #177 we can't generate intralinks to foreign impl items such as:

//! [String::from_utf8_lossy](String::from_utf8_lossy)
//! [char::is_ascii_lowercase](char::is_ascii_lowercase)

These fail because we can't resolve them with the paths field of the rustdoc json: we would need to have all index items of the standard library, and they are not included in rustdoc's output.

Now, there's a way to get the rustdoc json for the standard library with component rust-docs-json (see rust-lang/rust#76578 (comment)), but the json files, which will be installed in ~/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/share/doc/rust/json/, do not contain item ids consistent with the output of rustdoc in our crate (see "Foreign ID Lookup" in rust-lang/rust#106697).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant