-
-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack issues on Node 17 #785
Comments
I've had some discussions on this here: https://community.os-js.org/t/how-to-get-full-os-js/569 I'll see if there isn't a nice way to solve this without having to modify anything. |
Just updating this because this came up on Gitter. Node 17 is currently not supported because of changes with SSL of which older webpack (4) has no support for.
Doing This requires that the dev meta package (https://github.com/os-js/osjs-dev-meta) has it's dependencies updated and released as a new major version. This repo would then have to update this meta package. Downgrading/using node 16 (which is still LTS) is recommended. You can use https://github.com/nvm-sh/nvm to make this process simple. |
It is also possible to modify your fork of OS.js to transition everything entirely over to Webpack 5, that's what I have done with my project. It takes some time and a lot of refactoring but it is possible and it works pretty well. |
@ajmeese7 Feel free to submit PRs on that if possible. I would love to get transitioned, but simply don't have the time myself. |
@andersevenrud I can try, the biggest obstacle is with the |
Yeah, figures :)
Works for me. But you don't have to do it all at once. A working dev-meta with v5 and the distro/base-repo + osjs-client would suffice just to get the ball rolling. Maybe we can even automate the migration process here on everything else afterwards. |
Sounds like a plan, I'll get started on it as soon as I can |
I've split this out to an issue in the appropriate repository |
FYI to others, the issue persists with node v18 too. |
A friend tried deploying the web app on Heroku and it showed this error (pasted in the bin link below)
https://pastebin.com/aadQpxS9
The fix for this was adding
export NODE_OPTIONS=--openssl-legacy-provider;
to build script in package.jsonIf a check for nodejs version can be implemented using a bash script or the above could directly be put in package.json then deployment could be made easier for NodeJs versions >=17
The text was updated successfully, but these errors were encountered: