Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom in/out like google maps (double tap + drag) is very unreliable for some users #2617

Closed
bjohas opened this issue May 29, 2016 · 26 comments
Closed
Assignees

Comments

@bjohas
Copy link

bjohas commented May 29, 2016

It would be nice if osmand supported zoom in/out like google maps, i.e. double tap + drag up to zoom out, and double tap + drag down to zoom in. The double tap (without drag) should be maintained to zoom in. The large "+" and "-" buttons could (optionally) be hidden.

@stephan75
Copy link
Contributor

This feature is already implemented in Osmand, I can do this zooming in and out with only one finger.

Why are you not able to do this? What Osmand version?

@homersimpsons
Copy link
Contributor

Works for me too

@xmd5a2
Copy link
Contributor

xmd5a2 commented May 30, 2016

Already fixed

@xmd5a2 xmd5a2 closed this as completed May 30, 2016
@bjohas
Copy link
Author

bjohas commented May 30, 2016

I'm on the 2.3 nightly from yesterday, OSMAnd~ 2.4.0#3754M_2.3.

How do you zoom out with one finger? Same as google maps, i.e. tap plus tap-drag? Doesn't work for me.

(In case it's relevant, double tap to zoom in also didn't work in the 2.3 nightly for some time. However, I upgraded recently, and it's now working.)

@homersimpsons
Copy link
Contributor

homersimpsons commented May 30, 2016

@bjohas For me this (tap + tap-drag up/down) works; I'm on Osmand~ 2.3.5 from F-Droid

@scaidermern
Copy link
Contributor

Doesn't work for me in OsmAnd, neither in stable nor nightly. It always reacts on the first tap and uses it to center the position. Is there some specific plugin or setting required?

@bjohas
Copy link
Author

bjohas commented May 30, 2016

I've just tested this also with OsmAnd 2.3.5 (free version) and it doesn't work either. How do you get this to work?

@vrtareg
Copy link
Contributor

vrtareg commented May 30, 2016

Just tested on nightly builds.
Double tap on map and hold, then move up or down on screen to zoom in and out.
There is a slight glitch when map actually zooms in on double tap but reverts back to original zoom once detects holding.

@scaidermern
Copy link
Contributor

Now I got it working a few times. But this seems to be extreme buggy. Most of the time the map just gets centered, a marker gets set and the location lookup panel appears at the bottom. This works way better in Google Maps, unfortunately :/

@bjohas
Copy link
Author

bjohas commented May 30, 2016

Thanks - I can confirm that I managed to get this to work a few times too, but as @scaidermern mentioned, it's not reliable at all. Most of the time there's a zoom (like double tap), then a pin is dropped and tray opens, no further zoom in/out possible. (I.e. two separate gestures). Agreed that it works in goggle maps without problems.

@bjohas bjohas changed the title Zoom in/out like google maps (double tap + drag) Zoom in/out like google maps (double tap + drag) doesn't work reliably May 30, 2016
@bjohas
Copy link
Author

bjohas commented May 30, 2016

@xmd5a2 - I've changed the title of this issue - could you reopen?

@bjohas bjohas changed the title Zoom in/out like google maps (double tap + drag) doesn't work reliably Zoom in/out like google maps (double tap + drag) is very unreliable for some users May 30, 2016
@xmd5a2 xmd5a2 reopened this May 30, 2016
@bjohas
Copy link
Author

bjohas commented Jun 1, 2016

Latest nightly (2.3) - it seems that up to about zoom level 9, the double tap + drag works as advertised, but for higher zoom levels, it doesn't. Maybe that's where the different reports in this thread came from?

@bjohas
Copy link
Author

bjohas commented Jun 1, 2016

Also in the latest nightly, POIs/Favourites can only be selected through tap+hold, which is different from earlier versions, where a single tap selected the POI. Single tap (on POI or otherwise) now gives "destination not set".

Similarly the "orientation button" ("North is up", "magnetic", ...) needs a long press to change.

@bjohas
Copy link
Author

bjohas commented Jun 2, 2016

Latest nightly: The "orientation button" now works as expected again, but POIs still require long press.

@GaidamakUA
Copy link
Contributor

GaidamakUA commented Jun 7, 2016

Please check out tomorrow's nightly. Behaviour should be much more stable.
8b24f56

@bjohas
Copy link
Author

bjohas commented Jun 7, 2016

Great stuff - will do!

@scaidermern
Copy link
Contributor

scaidermern commented Jun 8, 2016

Not sure if it works slightly better. But 2.4.0#13192D still produces a marker on first tap wich in turn produces the annoying popup at the bottom which in turn stops dragging. So it still works rather unreliably for me, unfortunately :/

@vshcherb vshcherb assigned rominf and unassigned rominf Jun 8, 2016
@GaidamakUA
Copy link
Contributor

Hope this commit will finally solve the issue. 3d66b5b

@scaidermern
Copy link
Contributor

scaidermern commented Jun 9, 2016

Still produces 9/10 times a marker instead of zooming :( I wonder how/why it works for you.

@bjohas
Copy link
Author

bjohas commented Jun 9, 2016

Just tested this on build 3851, and similarly it only works very rarely. 9 out of 10 you still just get the marker, rather than zooming. (As noted above, for lower zoom levels it does work, and always did. But for higher zoom levels it doesn't.)

@vshcherb vshcherb assigned crimean and unassigned GaidamakUA Jun 13, 2016
@bjohas
Copy link
Author

bjohas commented Jun 15, 2016

I've tested this again - there seems to be some improvement at some zoom levels, but still not that reliable.

@crimean crimean closed this as completed in f5163ea Jul 1, 2016
@bjohas
Copy link
Author

bjohas commented Jul 4, 2016

Thanks! Works well now!

@bjohas
Copy link
Author

bjohas commented Jul 5, 2016

I've discovered another problem with this feature. Imagine moving the map downwards, i.e. repeatedly swipe down along the screen. On Google maps, this swipe is detected as a swipe, and the map just keeps moving down. However, in OSMAND, the map starts zooming. Maybe the tap-swipe needs to be constrained so that the first tap really is a tap, and not a swipe?

@crimean
Copy link
Contributor

crimean commented Jul 5, 2016

@bjohas do you use latest build?

@bjohas
Copy link
Author

bjohas commented Jul 5, 2016

Ah - no, I was a couple of days back! Just upgraded, and the problem is fixed - thanks!

@scaidermern
Copy link
Contributor

Works great now even when tapping on markers. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants