Skip to content
This repository has been archived by the owner on Sep 18, 2019. It is now read-only.

Add minfied JS and CSS to github #155

Closed
vgezer opened this issue Nov 12, 2014 · 6 comments
Closed

Add minfied JS and CSS to github #155

vgezer opened this issue Nov 12, 2014 · 6 comments
Labels

Comments

@vgezer
Copy link

vgezer commented Nov 12, 2014

The latest git version of core and chat app gives an exception after enabling the app.

Fatal error: Uncaught exception 'Exception' with message 'js file not found: script:js/vendor/angular formfactor: serverroot:/var/www/owncloud' in /var/www/owncloud/lib/private/template/resourcelocator.php:49 Stack trace: #0 /var/www/owncloud/lib/private/templatelayout.php(158): OC\Template\ResourceLocator->find(Array) #1 /var/www/owncloud/lib/private/templatelayout.php(103): OC_TemplateLayout::findJavascriptFiles(Array) #2 /var/www/owncloud/lib/private/template.php(183): OC_TemplateLayout->__construct('error', '') #3 /var/www/owncloud/lib/private/template/base.php(103): OC_Template->fetchPage() #4 /var/www/owncloud/lib/private/template.php(292): OC\Template\Base->printPage() #5 [internal function]: OC_Template::printExceptionErrorPage(Object(Exception)) #6 {main} thrown in /var/www/owncloud/lib/private/template/resourcelocator.php on line 49
@vgezer
Copy link
Author

vgezer commented Nov 14, 2014

Continuing in owncloud/core#12197.

@vgezer vgezer closed this as completed Nov 14, 2014
@LEDfan
Copy link
Contributor

LEDfan commented Nov 15, 2014

The error in the first post is caused because the JS isn't minimized, and ownCloud thus can't find these files. I still need to find a solution, so users can use the Git version without installing all the NodeJS dependencies.

@LEDfan LEDfan reopened this Nov 15, 2014
@LEDfan LEDfan changed the title Exception after enabling app Add minfied JS and CSS to github Nov 15, 2014
@Gomez
Copy link

Gomez commented Nov 19, 2014

I am interested in solving this too. I usually install apps from git.

The Solution to add the minified file to git isn't neat. What options does we have here?

@LEDfan LEDfan added the bug label Nov 21, 2014
@LEDfan
Copy link
Contributor

LEDfan commented Nov 21, 2014

@Gomez The reason that I didn't add the minimize file is because of git conflicts. (Git doens't understand the minimized file)
Maybe it's better to just concat the files and push them to git. I guess git can handle these file conflicts. When releasing I will minimize the files.

See 4a23434

@LEDfan
Copy link
Contributor

LEDfan commented Nov 30, 2014

@Gomez @wakeup I created a free jenkins server which builds the ownCloud Chat app. I asked in the mailing list to set up the webhooks. This means every time a commit is pushed a new package is built. I updated the README.md

@LEDfan LEDfan closed this as completed Nov 30, 2014
@Gomez
Copy link

Gomez commented Dec 1, 2014

Nifty solution :) If it works good, its a great reference for other apps.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants