Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Override default client ids/secrets #72

Open
SamuAlfageme opened this issue Aug 2, 2017 · 1 comment
Open

[Discussion] Override default client ids/secrets #72

SamuAlfageme opened this issue Aug 2, 2017 · 1 comment

Comments

@SamuAlfageme
Copy link
Contributor

SamuAlfageme commented Aug 2, 2017

For enterprise installations we've always been considering how interesting could be to limit the authorized clients to prevent unwanted clients from connecting instances.

Check for some environment/build-time variables set, if present, use them (e.g. on application's Makefile) to pre-populate the DB:

  • OAUTH2_DESKTOP_ID
  • OAUTH2_DESKTOP_SECRET
  • [OAUTH2_DESKTOP_REDIRECTION_URL]
  • ... (the same for iOS, Android clients)

If not, use the default values coming from #38 - the admin will always be able to generate more id/secret/url triplets and delete the existing ones.

Also, maybe would be interesting to offer a third option: don't pre-populate the DB and let the admin generate its own using the webUI provided (maybe too similar to the previous option - i.e. remove all existing pairs on a fresh app installation)

Thoughts? @michaelstingl @felixboehm @pmaier1 @DeepDiver1975

@SamuAlfageme SamuAlfageme changed the title [] Override default client ids/secrets Aug 2, 2017
@SamuAlfageme SamuAlfageme changed the title Override default client ids/secrets [Discussion] Override default client ids/secrets Aug 2, 2017
@pmaier1
Copy link
Contributor

pmaier1 commented Aug 3, 2017

Yes, we want this. Then we will also need an ability to add the ids/secrets in the clients used via e.g. ownBrander.

Edit: Ah perfect, you already opened a ticket here https://github.com/owncloud/ownbrander/issues/749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants