Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] simplify tracing configuration #92

Open
kulmann opened this issue May 14, 2020 · 3 comments
Open

[FR] simplify tracing configuration #92

kulmann opened this issue May 14, 2020 · 3 comments
Assignees
Labels
Exalated This issue is under sync p3-medium

Comments

@kulmann
Copy link
Member

kulmann commented May 14, 2020

Idea / Context

As of now tracing has to be configured for every service individually. While this follows configuration standards for microservices, it would be nice for ocis single binary to forward a single tracing configuration to all services. This is something that we already do for logging.

Implementation

Have a look at the accounts command in ocis single binary:
https://github.com/owncloud/ocis/blob/323ca3039e19f857d03957f8e09a6635badeb53e/pkg/command/accounts.go#L30

It sets the log config flags from ocis as the respective accounts config flags:

cfg.Accounts.Log.Level = cfg.Log.Level
cfg.Accounts.Log.Pretty = cfg.Log.Pretty
cfg.Accounts.Log.Color = cfg.Log.Color

We can do the same thing for tracing.

@butonic
Copy link
Member

butonic commented Jun 19, 2020

we need this for support and debbuging ourself

bonus points for

  • dockert compose setup
  • helm charts
  • docs

@micbar micbar transferred this issue from owncloud/ocis Jun 22, 2020
@kulmann kulmann self-assigned this Jun 23, 2020
@exalate-issue-sync exalate-issue-sync bot added Exalated This issue is under sync p3-medium labels Jun 23, 2020
@exalate-issue-sync
Copy link

Remote key is https://jira.owncloud.com/browse/OC-2016

@butonic
Copy link
Member

butonic commented Feb 16, 2021

We also need a way to dynamically increase the level of tracing for a specific user, group, user agent, role ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Exalated This issue is under sync p3-medium
Projects
None yet
Development

No branches or pull requests

2 participants