Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarks: plots not saved or compared for alloc_sz/_ct benchmarks #472

Open
FelixMcFelix opened this issue Mar 8, 2024 · 0 comments
Open

Benchmarks: plots not saved or compared for alloc_sz/_ct benchmarks #472

FelixMcFelix opened this issue Mar 8, 2024 · 0 comments
Labels
bug repo Automated tooling for dependency version management, CI, etc.

Comments

@FelixMcFelix
Copy link
Collaborator

FelixMcFelix commented Mar 8, 2024 •
edited
Loading

Criterion has some issues around handling of our allocation count/size benchmarks.

  • Values of 0 are never accepted, even for a custom measurement type. Unfortunately, we often desire having zero allocations!
  • The values produced by these benchmarks are causing NaN propagation somewhere within criterion. This directly prevents plotting of results as well as saving estimates/tukey values for our allocation benchmarks.

We should take some time to work on the upstream library to improve these pain points.
@FelixMcFelix FelixMcFelix changed the title Benchmarks:: Benchmarks: plots not saved or compared for alloc_sz/_ct benchmarks Mar 8, 2024
@FelixMcFelix FelixMcFelix mentioned this issue Mar 8, 2024
Merged
@FelixMcFelix FelixMcFelix added bug repo Automated tooling for dependency version management, CI, etc. labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug repo Automated tooling for dependency version management, CI, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FelixMcFelix