Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FRAME core] Refactor pallet benchmarking #194

Open
ggwpez opened this issue Apr 3, 2023 · 3 comments
Open

[FRAME core] Refactor pallet benchmarking #194

ggwpez opened this issue Apr 3, 2023 · 3 comments
Labels
D1-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. I4-refactor Code needs refactoring. T1-FRAME This PR/Issue is related to core FRAME, the framework.

Comments

@ggwpez
Copy link
Member

ggwpez commented Apr 3, 2023

The pallet benchmarking backend and measuring code is rotting away since three years and it becomes increasingly difficult to maintain.
Some medium-large scale refactoring of the involved code in the near future is a good idea IMHO. This would also allow for easier addition of new features and bug-fixing of existing ones.

@vivekvpandya
Copy link

@ggwpez could you please create small chunks of refactoring work? I would like to work on them but I don't know much to figure out myself.

@ggwpez
Copy link
Member Author

ggwpez commented Apr 4, 2023

@vivekvpandya this is a pretty big issue that I would like to either tackle myself or have another dev that is familiar with the code do. There is not much to split up - the code needs a complete face lift.

You can search for mentor issues, these are easier for external devs.
But thanks for asking, many people just start without asking 😅

@eskimor
Copy link
Member

eskimor commented Apr 6, 2023

One important aspect in my opinion: Either make sure to always measure the case where all parameters are 0 or otherwise ensure that the base case won't get over estimated. This is currently a blocker for getting proper weights for backed candidates.

@ggwpez ggwpez changed the title Refactor pallet benchmarking [FRAME Core] Refactor pallet benchmarking Apr 27, 2023
@ggwpez ggwpez changed the title [FRAME Core] Refactor pallet benchmarking [FRAME core] Refactor pallet benchmarking Apr 27, 2023
@juangirini juangirini transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added I4-refactor Code needs refactoring. T1-FRAME This PR/Issue is related to core FRAME, the framework. D1-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. and removed I7-refactor labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D1-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. I4-refactor Code needs refactoring. T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
Status: Backlog
Development

No branches or pull requests

5 participants