Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy docs on controllers #1150

Open
TarikGul opened this issue Nov 24, 2022 · 2 comments
Open

Remove legacy docs on controllers #1150

TarikGul opened this issue Nov 24, 2022 · 2 comments
Assignees
Labels
I5 - Documentation 📖 Documentation needs fixes or additions Q1 - Easy Issue is easy, good newcomer issue

Comments

@TarikGul
Copy link
Member

Before we had the OpenAPI specs we would write the controller docs above the actual controller. Since we have more organized documentation within SwaggerAPI we no longer need them. This is also important to remove since it can be confusing for contributors or maintainers when adding features, or new endpoints.

@Imod7 Thoughts?

@TarikGul TarikGul added the I5 - Documentation 📖 Documentation needs fixes or additions label Nov 24, 2022
@Imod7
Copy link
Contributor

Imod7 commented Nov 26, 2022

Yes, I agree! I will open a PR (and link this issue) to remove the comments from all the controller files.

@Imod7 Imod7 self-assigned this Nov 26, 2022
@Imod7
Copy link
Contributor

Imod7 commented Dec 3, 2022

@TarikGul I was looking at some of the controller files in order to remove all comments and I am seeing some parts that are not in the OpenAPI docs.

  • For example, in the AccountsBalanceInfoController the docs related to :

    • The detailed explanation of the returned values and
    • The Substrate References

    are not present in the OpenAPI.

  • Also, in other files there is other useful information that is also not present in OpenAPI. An example is in Staking Payouts.

Based on the above, in the comments of every controller I would opt for :

  • Adding a reference to the OpenAPI specs in the comments of every controller
  • Removing only the duplicate information compared to OpenAPI
  • Add/keep any additional information that is not included in the OpenAPI specs

Also, have a clear guideline for the contributors on what they need to update and where regarding the docs. This I think should include also the copyright information.

@TarikGul wdyt ?

@TarikGul TarikGul added the Q1 - Easy Issue is easy, good newcomer issue label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I5 - Documentation 📖 Documentation needs fixes or additions Q1 - Easy Issue is easy, good newcomer issue
Projects
None yet
Development

No branches or pull requests

2 participants