Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add version query param in transaction/material endpoint #1410

Closed
Imod7 opened this issue Mar 6, 2024 · 0 comments · Fixed by #1424
Closed

feat: add version query param in transaction/material endpoint #1410

Imod7 opened this issue Mar 6, 2024 · 0 comments · Fixed by #1424

Comments

@Imod7
Copy link
Contributor

Imod7 commented Mar 6, 2024

Proposed Change or Idea
Introduce a query parameter named version to the transaction/material endpoint.

A rough overview of its functionality is outlined below:

  • If the user specifies the version query param:
    • First call metadata_versions to retrieve the available metadata versions.
    • Verify if the specified version (from the query param) is present in the retrieved list from previous step.
    • If the version is found, return that version using metadata_at_version call.
    • If not found, either return an error message or the default version.
  • If the user omits the version query parameter, return the default version.

Additional Information
For further inspiration refer to subxt-cli, as this functionality has already been implemented there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant