Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/staking-payouts should be updated for staking.eraStakersClipped deprecation. #1411

Open
TarikGul opened this issue Mar 9, 2024 · 1 comment
Open

/staking-payouts should be updated for staking.eraStakersClipped deprecation. #1411

TarikGul opened this issue Mar 9, 2024 · 1 comment

Comments

@TarikGul
Copy link
Member

TarikGul commented Mar 9, 2024

Given polkadot-js/api#5771 there is change happening to eraStakersClipped that is going to be an internal breaking change. It is being replaced by ErasStakersPaged , and ErasStakersOverview .

The PR linked has all the information necessary to the original PR, and forum link describing the changes.
@Imod7 Imod7 mentioned this issue Apr 24, 2024
Merged
@Imod7
Copy link
Contributor

Imod7 commented Apr 24, 2024 •
edited
Loading

Pending Items

In addition to the changes in the linked PR, we need to:

  • Add tests for eras after the runtime upgrade . Cover cases :
    • for validator account with own exposure == 0 or not
    • if possible find an example with page != 0
  • Add tracking issue to remove completely the erasStakersClipped call as soon as it is removed from storage. The progress can be checked in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Imod7 @TarikGul