Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand prometheus metrics coverage to include custom route-based metrics #1469

Closed
filvecchiato opened this issue Aug 8, 2024 · 0 comments · Fixed by #1477
Closed

Expand prometheus metrics coverage to include custom route-based metrics #1469

filvecchiato opened this issue Aug 8, 2024 · 0 comments · Fixed by #1477
Labels
I8 - Enhancement Additional feature request P7 - Nice to Have Nice, but not urgent

Comments

@filvecchiato
Copy link
Contributor

Proposed Change or Idea

Currently the prometheus metrics expose standard metrics for all HTTP routes, and the metrics Class has a function to emit route-based metrics as well. Could be interesting to inject the metrics registry in the Route Controllers and have the specific controller emit custom metrics route based, encapsulating the metrics behaviour within the controller itself

Alternatives

A possibly simpler solution is to have route-based function resolvers within the Metrics Class

@filvecchiato filvecchiato added I8 - Enhancement Additional feature request P7 - Nice to Have Nice, but not urgent labels Aug 8, 2024
@filvecchiato filvecchiato linked a pull request Aug 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I8 - Enhancement Additional feature request P7 - Nice to Have Nice, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant