Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log slow requests as warnings #373

Closed
emostov opened this issue Dec 21, 2020 · 2 comments
Closed

Log slow requests as warnings #373

emostov opened this issue Dec 21, 2020 · 2 comments
Labels
I8 - Enhancement Additional feature request P7 - Nice to Have Nice, but not urgent Q1 - Easy Issue is easy, good newcomer issue

Comments

@emostov
Copy link
Contributor

emostov commented Dec 21, 2020

In order to help Sidecar maintainers and sysadmins better trouble shoot issues with the service and its deployment it may be helpful to log slow requests at the warn log level (or log an additional message at the warn log level with every slow request).

rel: #368

@danforbes
Copy link
Contributor

Could we allow Sidecar admins to configure what is considered a "slow" request? Is there existing Express middleware or something that handles this?

@emostov emostov added I8 - Enhancement Additional feature request P7 - Nice to Have Nice, but not urgent Q1 - Easy Issue is easy, good newcomer issue labels Mar 16, 2021
@TarikGul
Copy link
Member

Our recent benchmarks of all the endpoints have shown that consumption of resources vastly vary across each service, therefore it's harder to track what is "slow" and what isn't. I would argue a better source of truth should be the benchmarks and we work on performance regressions from there. Closing.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I8 - Enhancement Additional feature request P7 - Nice to Have Nice, but not urgent Q1 - Easy Issue is easy, good newcomer issue
Projects
None yet
Development

No branches or pull requests

3 participants