Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate adding finalized tag to block metadata #378

Closed
emostov opened this issue Jan 5, 2021 · 3 comments · Fixed by #386
Closed

Investigate adding finalized tag to block metadata #378

emostov opened this issue Jan 5, 2021 · 3 comments · Fixed by #386
Assignees
Labels
I8 - Enhancement Additional feature request

Comments

@emostov
Copy link
Contributor

emostov commented Jan 5, 2021

Proposed Change or Idea

If a user queries a block by ID it would be convenient for them to immediately know if it is considered finalized at the time of querying.

An alternate would be for the user to query blocks/head and compare that block's height to the block they are checking if it is finalized. If the height of the block they are checking finality for is higher then blocks/head they can assume it is not finalized

@dvdplm
Copy link
Contributor

dvdplm commented Jan 5, 2021

Seems like a good QoL improvement for users. I like it.

@TarikGul
Copy link
Member

@dvdplm @emostov Would you guys like a simple key such as isFinalized: boolean to be returned in the output reponse?

@emostov
Copy link
Contributor Author

emostov commented Jan 11, 2021

@TarikGul yes, I personally like finalized: boolean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I8 - Enhancement Additional feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants