Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intent data is not passed along to target activity #15

Closed
vishalpatel opened this issue Oct 23, 2014 · 3 comments
Closed

Intent data is not passed along to target activity #15

vishalpatel opened this issue Oct 23, 2014 · 3 comments

Comments

@vishalpatel
Copy link

I found that in ParseLoginDispatchActivity we drop the intent args passed by requestor. I breaks some workflows where the requestor has set args for profile activity to show user profile by arg (say "email") and then because of the loginDispatchActivity the args are lost.

@vishalpatel
Copy link
Author

I don't have access to push a branch and create pull request. But here is a patch
https://gist.github.com/vishalpatel/c5e20b3a5895db576118

@stanleyw
Copy link
Contributor

Thanks for making the patch! Please see https://github.com/ParsePlatform/ParseUI-Android/blob/master/CONTRIBUTING.md for instructions on making a pull request for your patch. That way we make sure you get proper credit for your work.

The patch looks good to me. The only minor comment I had was for style consistency with the rest of the repo, please use braces in the if statement even though it's single line and 2-space indent.

@ghost
Copy link

ghost commented Aug 4, 2015

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants