Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeVM require config key cannot be false #456

Closed
takamonowhite opened this issue Jul 31, 2022 · 1 comment · Fixed by #457
Closed

NodeVM require config key cannot be false #456

takamonowhite opened this issue Jul 31, 2022 · 1 comment · Fixed by #457

Comments

@takamonowhite
Copy link

For my projects I am generally more comfortable to explicitly set default config values. But seems like I cannot pass false to require config key when creating new NodeVM.

image
@XmiliaH XmiliaH linked a pull request Jul 31, 2022 that will close this issue
Allow false for require option #457
Merged
@XmiliaH
Copy link
Collaborator

XmiliaH commented Jul 31, 2022

Thanks for the feedback. Changed the allowed values to boolean | VMRequire | undefined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow false for require option XmiliaH/vm2
2 participants
@XmiliaH @takamonowhite