New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comparison table design guidelines #3963

Closed

mmenestr opened this issue Apr 12, 2024 · 1 comment · Fixed by #4006

Assignees

Labels

PF5 Design guidelines

Collaborator

mmenestr commented Apr 12, 2024

We have no guidelines around what a comparison table should look like in PF.
Need to add guidelines that cover the following things:

Where the value vs parameter should be placed
Whether to use vertical divider lines between items being compared
Whether to use grey background color to distinguish parameter values / sticky column from rest of table, and if so, which shade

mmenestr added the PF5 Design guidelines label

mmenestr self-assigned this

Collaborator Author

mmenestr commented May 6, 2024

Doc: https://docs.google.com/document/d/1Z6LyyqYTxKxCtYwRVywttHjL7v15AFt7FyAXJB8zNK0/edit#heading=h.1iczefh0hkly

mmenestr mentioned this issue

add comparison table to table guidelines #4006

Merged

jessiehuff closed this as completed in #4006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment