Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeEditor - allow additional props to monaco-editor #10077

Closed
kmcfaul opened this issue Feb 12, 2024 · 0 comments · Fixed by #10080
Closed

CodeEditor - allow additional props to monaco-editor #10077

kmcfaul opened this issue Feb 12, 2024 · 0 comments · Fixed by #10080
Assignees

Comments

@kmcfaul
Copy link
Contributor

kmcfaul commented Feb 12, 2024

Add a new prop (maybe editorProps) that spreads additional properties to the monaco-editor Editor component, to allow further customization of the editor.

At a minimum, this will allow the beforeMount property of Editor to be passed, which should resolve the issue of monaco-yaml autocomplete not functioning with @monaco-editor/react (via calling monaco-yaml's configureMonacoYaml in the beforeMount handler). The Readme should also be updated to mention this requirement for monaco-yaml usage.

@kmcfaul kmcfaul added Feature end user feature that requires design to define this, i.e. changes or augments the user experience. and removed Feature end user feature that requires design to define this, i.e. changes or augments the user experience. labels Feb 12, 2024
@kmcfaul kmcfaul self-assigned this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant