Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - [CodeEditor] - loads files from CDN instead of node_modules #10664

Open
christianvogt opened this issue Jun 26, 2024 · 0 comments
Open
Labels

Comments

@christianvogt
Copy link
Contributor

christianvogt commented Jun 26, 2024

Describe the problem

CodeEditor utilizes the monaco editor under the covers. When the component loads, several files are downloaded from external CDN. Expectation is for all dependencies to come pre-packaged with patternfly.

A link to the documentation for this:
https://github.com/suren-atoyan/monaco-react?tab=readme-ov-file#use-monaco-editor-as-an-npm-package

How do you reproduce the problem?

Visit the patternfly CodeEditor component page: https://www.patternfly.org/components/code-editor

Observe in the network requests several files related to monaco editor loading from external CDN:
image

Expected behavior

Files should be packaged node_modules with no reliance on external CDN.

Is this issue blocking you?
List the workaround if there is one.

import { loader } from '@monaco-editor/react';
loader.config({ monaco });

What is your product and what release date are you targeting?
RHOAI 2.12

Any other information?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs triage
Development

No branches or pull requests

1 participant