-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: Cmd+Z / Ctrl+Z on workspace entry overrides files #1786
Labels
Comments
We only change the Since #1737 is ongoing, this issue might be out of date soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
If a user navigates from workspace A to workspace B and makes no edits on a file to workspace B then clicks Cmd+Z / Ctrl+Z, the content in that file is completely overridden by the content from the corresponding file in workspace A.
More generally, if a user navigates from workspace A to workspace B, makes x edits in workspace B then clicks Cmd+Z / Ctrl+Z x+1 times, the content in that file is also completely overridden by the content from the corresponding file in workspace A.
I believe this to be because what's happening underneath the hood is the currentWorkspace state is being swapped when a user navigates to a different workspace, so the "previous" state that Cmd+Z tries to go back to is what was in that previous workspace.
Screen.Recording.2024-06-10.at.10.16.22.AM.mov
Screen.Recording.2024-06-10.at.10.19.28.AM.mov
(the only keys clicked in these examples are Cmd+Z, no copy paste)
To Reproduce
Have at least two workspaces in your saved tab
Click on workspace A
Click on workspace B
Click Cmd+Z / Ctrl+Z (windows) on workspace B
Or
Have at least two workspaces in your saved tab
Click on workspace A
Click on workspace B
Make x edits on workspace B
Click Cmd+Z / Ctrl+Z (windows) x+1 times on workspace B
The text was updated successfully, but these errors were encountered: