-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[strength] Need to re-work how movement tracking + class plan work together #453
Comments
Ah, no this is not related to this particular issue, but it is important. P2G has to explicitly map every Peloton Exercise to a Garmin exercise. This error message calls out that you preformed some exercises that P2G doesn't yet know how to map. I just pushed a change that now maps Lateral Raise and Supinated Row, you can download that version here. |
I have started a separate issue thread #463, not sure if this is annoying for you (would you like me to track this in the other thread?), sorry in advance...I have a few more mapping errors Reverse Fly |
Thanks @neildsb , I don't mind dedicated issues for the Mapping Errors, helps me keep track of which ones I have completed already. I went ahead and added those exercises you mentioned into 3.5.0-rc version, but haven't had a chance to look into the bug you found yet (#463). Will do that as soon as I get some free time. |
Current logic will pull Exercise info from either the MovementTrackerData OR the Class Plan. But the below class demonstrates that they really ought to be used together.... which means we need much more robust mapping logic in P2G.
Movement tracking: https://api.onepeloton.com/api/ride/94826b05633941f3afdb890ab5f35253/details?stream_source=multichannel&include=sampled_top_tags
Class Plan: https://api.onepeloton.com/api/workout/77eb0dff9b4742958203535cd9e98d0f
The text was updated successfully, but these errors were encountered: