Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update min required PHP version and fix deprecation warnings #845

Closed
stepozer opened this issue Apr 13, 2023 · 3 comments · Fixed by #846
Closed

Update min required PHP version and fix deprecation warnings #845

stepozer opened this issue Apr 13, 2023 · 3 comments · Fixed by #846

Comments

@stepozer
Copy link

Right now minimal supported PHP version is 8.0:

https://www.php.net/supported-versions.php

I suggest up minimal PHP version to 7.0 or 7.4 and fix this warnings that is I actually get in PHP 8.2:

1x: Method "ArrayAccess::offsetExists()" might add "bool" as a native return type declaration in the future. Do the same in implementation "Imagine\Imagick\Layers" now to avoid errors or add an explicit @return annotation to suppress this message.
1x: Method "ArrayAccess::offsetGet()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "Imagine\Imagick\Layers" now to avoid errors or add an explicit @return annotation to suppress this message.
1x: Method "ArrayAccess::offsetSet()" might add "void" as a native return type declaration in the future. Do the same in implementation "Imagine\Imagick\Layers" now to avoid errors or add an explicit @return annotation to suppress this message.
1x: Method "ArrayAccess::offsetUnset()" might add "void" as a native return type declaration in the future. Do the same in implementation "Imagine\Imagick\Layers" now to avoid errors or add an explicit @return annotation to suppress this message.
1x: Method "Countable::count()" might add "int" as a native return type declaration in the future. Do the same in implementation "Imagine\Imagick\Layers" now to avoid errors or add an explicit @return annotation to suppress this message.
1x: Method "Iterator::current()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "Imagine\Imagick\Layers" now to avoid errors or add an explicit @return annotation to suppress this message.
1x: Method "Iterator::key()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "Imagine\Imagick\Layers" now to avoid errors or add an explicit @return annotation to suppress this message.
1x: Method "Iterator::next()" might add "void" as a native return type declaration in the future. Do the same in implementation "Imagine\Imagick\Layers" now to avoid errors or add an explicit @return annotation to suppress this message.
1x: Method "Iterator::rewind()" might add "void" as a native return type declaration in the future. Do the same in implementation "Imagine\Imagick\Layers" now to avoid errors or add an explicit @return annotation to suppress this message.
1x: Method "Iterator::valid()" might add "bool" as a native return type declaration in the future. Do the same in implementation "Imagine\Imagick\Layers" now to avoid errors or add an explicit @return annotation to suppress this message.

If you need I can create PR for it

@mlocati
Copy link
Collaborator

mlocati commented Apr 14, 2023

What about #846?

@stepozer
Copy link
Author

stepozer commented Apr 17, 2023

@mlocati tested this changes on my local project (changed files into the same approach) and it is works for me (no warnings anymore). Can you please merge it into master and push a new version?

Thank you!

@mlocati
Copy link
Collaborator

mlocati commented Apr 17, 2023

Can you please merge it into master and push a new version?

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants