Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing advanced functions on GP26, 27, & 28 #14

Closed
ZodiusInfuser opened this issue Mar 3, 2023 · 7 comments · Fixed by #15
Closed

Missing advanced functions on GP26, 27, & 28 #14

ZodiusInfuser opened this issue Mar 3, 2023 · 7 comments · Fixed by #15

Comments

@ZodiusInfuser
Copy link

These pins have SPI functionality that the advanced view does not show.

image

Is this an easy enough thing for me to edit and raise a PR for? Looks like they would need a 5th column on the UI, so perhaps beyond me web skills?

@Gadgetoid
Copy link
Collaborator

Whew, that's a rather awkward problem. I might have to eschew the original pinout diagram layout in order to better incorporate the ADC functions.

I guess Ground / AGround is rather redundant, and ADC_VREF1 being moved one spot over is also slightly weird.

What if ADCn was combined with GPn in the first label, recoloured to ADC colour and SPI got its rightful slot.

Like this:

image

@ZodiusInfuser
Copy link
Author

That compacting seems okay to me, but then I'm not the primary audience of the non-advanced mode.

@Gadgetoid
Copy link
Collaborator

I don't like the compacting much, but I think it's a necessary evil to avoid occluding pin functions.

All the I2C, SPI and UART RX/TX that's currently not shown by default can be added and make the default view a little more visually balanced 😆

@lurch
Copy link
Contributor

lurch commented Mar 3, 2023

Works for me 😉

@Gadgetoid
Copy link
Collaborator

Proposed default view:

image

The "ADC" toggle becomes redundant... well I say "becomes", it was never all that useful.

Still need to address #13

@ZodiusInfuser
Copy link
Author

Could be argued that those new additional SPI pins should not appear in the default view, since they're not complete blocks? Or at least the one on pin 29? If it were to stay, then the I2C0 SDA and UART0 TX on GP28 should be shown in the default view too 🤔 . Doing that would then mean the advance just adds the CTS, RTS and PWMs.

The addition of the UART on GP20 and GP21 is good. Can't see a reason that would have been excluded on the default.

@Gadgetoid Gadgetoid mentioned this issue Mar 3, 2023
@Gadgetoid
Copy link
Collaborator

Ugh, darn CSS changes are being stubborn about re-loading. Might need a cache-buster. Almost as frustrating to refresh as 7-colour e-Ink 💀

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants