Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking upstream] Remove erasStakersClipped from api.derive.staking._erasExposure when applicable #5819

Closed
TarikGul opened this issue Mar 13, 2024 · 5 comments

Comments

@TarikGul
Copy link
Member

Via #5771 api.derive.staking._erasExposure needed to change its internal functionality to accommodate the new changes. Currently the derive has forward and backwards compatibility via #5815.

That being said, once all relay chain runtimes are updated to 1004000 it is safe to say we can remove the erasStakersClipped, and have support for only erasStakersPaged. This means we can also adjust the types to ensure there is a single source of truth for the _eraExposure.

This is a tracking issue to ensure we stay on top of it and will be added to the projects board tracking column.

@ScepticMatt
Copy link

how would you get erasStakersClipped from api.at(hash) then? I haven't been able to use derive API with historical data

@TarikGul
Copy link
Member Author

TarikGul commented Apr 18, 2024

That being said, once all relay chain runtimes are updated to 1004000 it is safe to say we can remove the erasStakersClipped, and have support for only erasStakersPaged

This is referring only to the functionality in the derive, not api.query

@TarikGul TarikGul changed the title [Tracking upstream] Remove erasStakersClipped when applicable [Tracking upstream] Remove erasStakersClipped from api.derive.staking._erasExposure when applicable Apr 18, 2024
@TarikGul
Copy link
Member Author

I changed the title to be more less confusing.

@TarikGul
Copy link
Member Author

Keeping erasStakersClipped as a future backwards compatible even though the migration is done with Polkadot. I just want to ensure any other chains who use this functionality don't have their api broken.

@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants