Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finalise the selection API #584

Closed
grahamgower opened this issue Sep 29, 2020 · 5 comments
Closed

finalise the selection API #584

grahamgower opened this issue Sep 29, 2020 · 5 comments
Milestone

Comments

@grahamgower
Copy link
Member

#462 added support for doing single locus selection in a flexible way, and DFEs in an inflexible way. Probably the API for using this will need to change as we demand more, or more complex, features. @jeromekelleher has expressed concern over the location of this code (it currently lives in the ext submodule, which is unecessary), and the ExtendedEvents objects.

@mufernando
Copy link
Member

why do you think the DFE API is inflexible?

@grahamgower
Copy link
Member Author

Possibly just a poor choice of words. :) Combining the MutationType class with a new GenomicElementType class would certainly make it more flexible though.

@izabelcavassim
Copy link
Member

izabelcavassim commented Sep 23, 2021

I agree with @jeromekelleher that the ext submodule is unnecessary, maybe we could fix this @grahamgower and @petrelharp, before we push the DFE_class PR?

@petrelharp
Copy link
Contributor

Let's do it in a separate PR.

@nspope
Copy link
Collaborator

nspope commented Sep 26, 2022

Closed by #1341. Selection-related functions are still living in ext, I'll make a new issue to track moving these somewhere more appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants