Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data frame): Add support for narwhals and ibis #1511

Open
schloerke opened this issue Jul 9, 2024 · 0 comments
Open

feat(data frame): Add support for narwhals and ibis #1511

schloerke opened this issue Jul 9, 2024 · 0 comments
Labels
data frame Related to @render.data_frame enhancement New feature or request
Milestone

Comments

@schloerke
Copy link
Collaborator

Would be neat to have @render.data_frame add support for narwhals and ibis which are abstractions around other data frame libraries.

Hopefully we can use the "we can type it but don't need to load it" approach that PdDataFrame and PlDataFrame used.


Implementation details:

  • Consolidate all methods in _tbl_data.py to be in grouped classes (by data frame type) that inherits from a base ABC class as all data frame helper methods are necessary and we know the type beforehand
  • We do not need to necessarily expose the base class for external integration
  • Is it possible to use narwhals as the implementation vehicle for all data methods?
@schloerke schloerke added enhancement New feature or request data frame Related to @render.data_frame labels Jul 9, 2024
@schloerke schloerke added this to the v1.2.0 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data frame Related to @render.data_frame enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant