Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maximizing a c.window() causes infinite flickering #33

Closed
sla-te opened this issue Oct 31, 2020 · 11 comments
Closed

maximizing a c.window() causes infinite flickering #33

sla-te opened this issue Oct 31, 2020 · 11 comments

Comments

@sla-te
Copy link
Contributor

sla-te commented Oct 31, 2020

No description provided.

@sla-te
Copy link
Contributor Author

sla-te commented Nov 1, 2020

bump

@potocpav
Copy link
Owner

potocpav commented Nov 2, 2020

Maximizing the application? Works fine for me on Ubuntu. Is it a Windows issue?

@sla-te
Copy link
Contributor Author

sla-te commented Nov 2, 2020

Maximizing a window inside the rendered window using the internal window system which allows to drag a window into the middle to maximize it. Yes on Windows.

@sla-te
Copy link
Contributor Author

sla-te commented Nov 2, 2020

@potocpav
Copy link
Owner

potocpav commented Nov 3, 2020

Thanks for the information. I was able to reproduce. I already had a similiar issue in the past, but I can't remember what was the cause. Will investigate.

@potocpav
Copy link
Owner

potocpav commented Nov 3, 2020

perhaps related to ocornut/imgui#2286

@potocpav
Copy link
Owner

potocpav commented Nov 3, 2020

Caused by nested windows (ocornut/imgui#2109 (comment)). You shouldn't really nest windows, since the code inside a window is only executed when the window is open. This leads to a feedback loop:

  1. Window is rendered, which causes a nested window to be rendered
  2. The nested window displays in a tab, which hides the parent window
  3. Parent window doesn't render because it's hidden. This causes the child window to disappear.
  4. The parent window is now visible again, and it is rendered.

That's the reason the docs for window say they can't be nested. I will add this issue to the docs & faq.

EDIT: I will push the changes after your PR is merged.

@sla-te
Copy link
Contributor Author

sla-te commented Nov 3, 2020

Alright, great, ill push the final ammendmends as discussed in the PR in a bit.

@potocpav
Copy link
Owner

potocpav commented Nov 4, 2020

Updated docs. Closing.

@potocpav potocpav closed this as completed Nov 4, 2020
@sla-te
Copy link
Contributor Author

sla-te commented Nov 4, 2020

Can you implement & push a workaround for this problem according to what how it is currently implemented here: https://github.com/chwba/concur_gui_test/blob/847d94a4d85271131023d2435a9c23d1698e6e39/src/features/nice_feature/nice_feature_gui.py#L59

@potocpav
Copy link
Owner

potocpav commented Nov 6, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants