Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for version comparisons with database format #22

Open
kyleniemeyer opened this issue Sep 17, 2016 · 2 comments
Open

Add support for version comparisons with database format #22

kyleniemeyer opened this issue Sep 17, 2016 · 2 comments
Milestone

Comments

@kyleniemeyer
Copy link
Member

No description provided.

@kyleniemeyer kyleniemeyer added this to the v0.1 milestone Sep 17, 2016
@bryanwweber bryanwweber self-assigned this Sep 18, 2016
@bryanwweber
Copy link
Member

I'm not sure what this actually entails. Should features be disabled if an "old" version of the database is specified? That seems pretty complicated, let alone trying to have totally different behavior of the same feature if a specific database schema version is specified. I vote to push this to at least 1.0, and generally, to try our best to avoid backwards-incompatible changes to the database schema.

@kyleniemeyer
Copy link
Member Author

I'm not quite sure either. I believe we were thinking more along the lines of specifying the ChemKED (CK? CKED?) format used when creating the file, so that the PyKED could check it and gracefully handle any breaking changes. That does seem like it would be complicated, though.

I agree that this can be pushed off to 1.0. Ideally, we should be able to only add new features, rather than change or delete things, starting at that point.

@kyleniemeyer kyleniemeyer modified the milestones: v1.0, v0.1 Nov 26, 2016
@bryanwweber bryanwweber removed their assignment Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants