Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What happens if an optional field is included but is blank? #82

Open
bryanwweber opened this issue Oct 4, 2017 · 2 comments
Open

What happens if an optional field is included but is blank? #82

bryanwweber opened this issue Oct 4, 2017 · 2 comments

Comments

@bryanwweber
Copy link
Member

Code sample, preferably able to be copy-pasted and run with no changes

apparatus:
  kind: rapid compression machine
  institution:
  facility:

Expected behavior

Guess we need to decide this

Actual behavior, including any error messages

No idea 😄

@kyleniemeyer
Copy link
Member

For expected behavior, I guess I would like the ChemKED object either to be None or not present—whatever the behavior is for the optional field not being present.

@bryanwweber bryanwweber changed the title What happens if an optional field is included by blank? What happens if an optional field is included but is blank? Oct 11, 2017
@bryanwweber
Copy link
Member Author

Currently, this raises an exception during validation with the value 'null value not allowed'. When we implement #78, we can have a special case if we want to set the value to None if its null, or we can require the user to delete the offending field.

My preference is for deletion (no need to clutter up the file).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants