Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is there a way to cache DOI lookups in the test suite #94

Open
Kypore1 opened this issue Oct 25, 2017 · 3 comments
Open

Is there a way to cache DOI lookups in the test suite #94

Kypore1 opened this issue Oct 25, 2017 · 3 comments

Comments

@Kypore1
Copy link
Contributor

Kypore1 commented Oct 25, 2017

As is it takes a long time to validate all the files because it has to download them all each time. Could we look into adding something to cache the files?
@kyleniemeyer
Copy link
Member

We did start to look at why the test suite is so slow in #86

@bryanwweber
Copy link
Member

Indeed, and @Kypore1 was running the code from before the commits that fixed #86. Let's see if the speed improves after updating to master. I still think this might be a good idea though... we can download JSON files of the message response or something in a directory that can be "cleaned" with a separate command

@kyleniemeyer
Copy link
Member

Sure, maybe we can set up a list of all the queries for the tests and do it all in one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kyleniemeyer @bryanwweber @Kypore1