Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic <p> tags after first paragraph in table cells with multiple paragraphs #935

Open
tw77 opened this issue Jan 24, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@tw77
Copy link
Contributor

tw77 commented Jan 24, 2022

Description

In a standard (not Tablepress) table cell containing multiple paragraphs, the first paragraph is given a default, appropriate font unless specified. It is not automatically placed within <p> tags. All subsequent paragraphs, however, are automatically placed within <p> tags in the webbook output. This happens without any user intervention in the Text editor, and it gives additional paragraphs a different, unexpected font:

Code in Text editor
texteditor

Appearance in webbook
cell

Webbook HTML
inspect

This seems to happen regardless of the book's Theme (tested with McLuhan, Malala, Adunis, Andreessen).

A cumbersome workaround is to place every paragraph in a table within appropriately styled <p> tags. The default <p> tags are likely not hoped for in the context of a multi-paragraph table cell. Their automatic inclusion from the second paragraph onwards is experienced as a bug.

Steps to Reproduce

  1. In a book chapter, create a table with at least one cell.
  2. Write two or more paragraphs within that cell with no particular styling.
  3. Preview or save and view the chapter.

Expected behavior: All paragraphs have the same, appropriate font.

Actual behavior: All paragraphs after the first paragraph have a different, larger font.

@tw77 tw77 added the bug Something isn't working label Jan 24, 2022
@tw77
Copy link
Contributor Author

tw77 commented Mar 1, 2022

This is affecting another client here: https://pressbooks.zendesk.com/agent/tickets/9399

@tw77 tw77 self-assigned this Mar 1, 2022
@SteelWagstaff
Copy link
Member

Desired behaviour:

  1. all content inside td elements is treated the same way (wrapped in a p element)
  2. we appropriately target td p elements to display the way we want td content to display now

@jocelynpb2
Copy link

This is affecting another client here: https://pressbooks.zendesk.com/agent/tickets/13182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants