Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy / pre-commit issue #1277

Open
eriktaubeneck opened this issue Sep 17, 2024 · 0 comments
Open

clippy / pre-commit issue #1277

eriktaubeneck opened this issue Sep 17, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@eriktaubeneck
Copy link
Member

This warning is legit, however it doesn't catch it for me locally.

It does catch it for me if I run

cargo clippy --features "cli web-app test-fixture" -- -D warnings

so I believe the issue is that it requires those features, but the command we run in pre-commit has a conflicting feature (real-world-infra).

I'm actually even more confused as to how/why this catches it on the Github checker, because it seems to be calling the exact same command as in pre-commit.

Not crucial, this is a fairly small little script, but it would be nice to have to work in both places.

@eriktaubeneck eriktaubeneck added the bug Something isn't working label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant