Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Stop scan after X timeouts #259

Closed
c3l3si4n opened this issue May 5, 2021 · 4 comments · Fixed by #358 or #370
Closed

[Feature] Stop scan after X timeouts #259

c3l3si4n opened this issue May 5, 2021 · 4 comments · Fixed by #358 or #370
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.

Comments

@c3l3si4n
Copy link

c3l3si4n commented May 5, 2021

it would be nice to have a feature where httpx closes after X timeouts.
@ehsandeep
Copy link
Member

@celsec here X number is defined for a domain or a total number of timeouts from all inputs? getting timeout is common keeping passive domains as input, what's the use case of this over -timeout flag where you can define timeout per domain?

@ehsandeep ehsandeep added the Type: Question A query or seeking clarification on parts of the spec. Probably doesn't need the attention of all. label May 5, 2021
@c3l3si4n
Copy link
Author

c3l3si4n commented May 8, 2021

Total number of timeouts from all inputs. Sometimes i am fetching a few hundreds urls in a single website with httpx, but then the site dies and the scan gets stuck. ( using -timeout is not a good solution for this issue )

What i'm thinking is something like Burp Suite Scanner's behaviour, where it will stop the scan after a X amount of connection errors.

@ehsandeep ehsandeep added the Type: Discussion Some ideas need to be planned and disucssed to come to a strategy. label May 13, 2021
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes. and removed Type: Discussion Some ideas need to be planned and disucssed to come to a strategy. Type: Question A query or seeking clarification on parts of the spec. Probably doesn't need the attention of all. labels Aug 16, 2021
@ehsandeep ehsandeep linked a pull request Aug 16, 2021 that will close this issue
Adding option to skip remaining paths on unresponsive host #358
Merged
@ehsandeep
Copy link
Member

@c3l3si4n this is now added into dev branch, check following PR for details of uses:- #358

@ehsandeep ehsandeep linked a pull request Aug 17, 2021 that will close this issue
v1.1.2 Release preparation #370
Merged
@ehsandeep
Copy link
Member

@c3l3si4n this is now supported in the latest release, following errors are considered for this flag:-

"no address found for host"
"no address found for host (Client.Timeout exceeded while awaiting headers)"
"context deadline exceeded (Client.Timeout exceeded while awaiting headers)"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Enhancement Most issues will probably ask for additions or changes.
Projects
None yet
Milestone
No milestone
2 participants
@ehsandeep @c3l3si4n