Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] httpx v1.0.6 Issue with Printing path info to CLI when port is used #276

Closed
vysecurity opened this issue May 17, 2021 · 6 comments · Fixed by #286
Closed

[Issue] httpx v1.0.6 Issue with Printing path info to CLI when port is used #276

vysecurity opened this issue May 17, 2021 · 6 comments · Fixed by #286
Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@vysecurity
Copy link

vysecurity commented May 17, 2021

Current:-

echo https://lapp.corp.vipshop.com:8443/core | httpx -status-code -title
https://lapp.corp.vipshop.com [302] [Object moved]

I would expect it to show the full URL not just the protocol, domain, and port.

Expected:-

echo https://lapp.corp.vipshop.com:8443/core | httpx -status-code -title
https://lapp.corp.vipshop.com:8443/core [302] [Object moved]
@vysecurity
Copy link
Author

Seems it's a confirmed bug:
image

@vysecurity vysecurity changed the title URL Bug? HTTP Print URL bug / request bug, when there is a port specified in the URL May 17, 2021
@vysecurity vysecurity changed the title HTTP Print URL bug / request bug, when there is a port specified in the URL [BUG] HTTP Print URL bug / request bug, when there is a port specified in the URL May 17, 2021
@ehsandeep
Copy link
Member

@vysecurity looks like an issue with printing to CLI, the request is working as intended.

echo https://lapp.corp.vipshop.com:8443/core | httpx -status-code -title -silent -json | jq .

{
  "timestamp": "2021-05-17T16:35:35.102594+05:30",
  "scheme": "https",
  "port": "8443",
  "path": "/core",
  "body-sha256": "c79580e2d6196b4770e20f74a5571374c7eb5b0b669ba50639d2e5f60bcb79e3",
  "header-sha256": "14e85230107f5788892c26d0a8bf35e33fefc490e1c4d256548ab64a10a18ed4",
  "a": [
    ""
  ],
  "url": "https://lapp.corp.vipshop.com:8443/core",
  "location": "/Login.aspx?ReturnUrl=%2fcore",
  "title": "Object moved",
  "webserver": "nginx",
  "content-type": "text/html",
  "method": "GET",
  "content-length": 146,
  "status-code": 302,
  "response-time": "1.686565834s"
}

@ehsandeep ehsandeep changed the title [BUG] HTTP Print URL bug / request bug, when there is a port specified in the URL [Issue] Issue with Printing path info to CLI when port is used May 17, 2021
@ehsandeep ehsandeep added Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. Priority: Medium This issue may be useful, and needs some attention. Status: Available No one has claimed responsibility for resolving this issue labels May 17, 2021
@ehsandeep
Copy link
Member

This is something that got introduced in v1.0.6 release as detailed here #277

@ehsandeep ehsandeep changed the title [Issue] Issue with Printing path info to CLI when port is used [Issue] httpx v1.0.6 Issue with Printing path info to CLI when port is used May 17, 2021
@ehsandeep ehsandeep modified the milestone: v1.0.7 May 22, 2021
@ehsandeep
Copy link
Member

Closing from here, as this will be handled in #277

@ehsandeep ehsandeep removed the Status: Available No one has claimed responsibility for resolving this issue label May 22, 2021
@ehsandeep
Copy link
Member

@vysecurity This is now fixed in #282

@ehsandeep ehsandeep added the Status: Completed Nothing further to be done with this issue. Awaiting to be closed. label May 25, 2021
@ehsandeep ehsandeep linked a pull request May 26, 2021 that will close this issue
@ehsandeep
Copy link
Member

@vysecurity the fix is now live in the latest release of httpx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium This issue may be useful, and needs some attention. Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants