Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: support -simhash #489

Closed
M09Ic opened this issue Jan 11, 2022 · 3 comments · Fixed by #517 or #532
Closed

Feature request: support -simhash #489

M09Ic opened this issue Jan 11, 2022 · 3 comments · Fixed by #517 or #532
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed.
Milestone

Comments

@M09Ic
Copy link
Contributor

M09Ic commented Jan 11, 2022

No description provided.

@M09Ic M09Ic added the Type: Enhancement Most issues will probably ask for additions or changes. label Jan 11, 2022
@ehsandeep
Copy link
Member

@M09Ic Can you also include information for the below fields?

  • Please describe your feature request:
  • Describe the use case of this feature:

@ehsandeep ehsandeep added Type: Discussion Some ideas need to be planned and disucssed to come to a strategy. and removed Type: Enhancement Most issues will probably ask for additions or changes. labels Jan 11, 2022
@M09Ic
Copy link
Contributor Author

M09Ic commented Jan 12, 2022

Sorry, I forgot to add a description.
Before, I used simhash to determine the page similarity. So I want to add simhash probe for body/header/all.

I used to use this library:https://github.com/mfonda/simhash

@M09Ic
Copy link
Contributor Author

M09Ic commented Jan 12, 2022

I think, we can add the -hash [hashtype] option
for example:
choice
-hash [md5/sha1/sha256/mmh3/simhash]

multi args
-hash md5,simhash

@ehsandeep ehsandeep linked a pull request Feb 15, 2022 that will close this issue
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Type: Discussion Some ideas need to be planned and disucssed to come to a strategy. labels Feb 15, 2022
@ehsandeep ehsandeep added this to the v1.2.0 milestone Mar 1, 2022
@ehsandeep ehsandeep linked a pull request Mar 1, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed.
Projects
None yet
2 participants