Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Deduplicate alerts definition via allOf parameter #1638

Closed
mxinden opened this issue Nov 26, 2018 · 0 comments · Fixed by #1640
Closed

api: Deduplicate alerts definition via allOf parameter #1638

mxinden opened this issue Nov 26, 2018 · 0 comments · Fixed by #1640
Milestone

Comments

@mxinden
Copy link
Member

mxinden commented Nov 26, 2018

Now that the fix for OpenAPITools/openapi-generator#1465 was merged, we can deduplicate the alert definition in the openapi.yaml spec like we did for silences.

More details:

# Shared properties in gettableAlert and postableAlert could also be
# de-duplicated via the `allOf` parameter like it is done with silences. So
# far this is blocked as the elm generator does not support it. For more
# details see https://github.com/OpenAPITools/openapi-generator/issues/1465.
gettableAlert:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant