Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Alertmanager API v1 #2469

Closed
simonpasquier opened this issue Jan 29, 2021 · 5 comments · Fixed by #2970
Closed

Remove Alertmanager API v1 #2469

simonpasquier opened this issue Jan 29, 2021 · 5 comments · Fixed by #2970

Comments

@simonpasquier
Copy link
Member

Alertmanager API v2 is available since v0.16.0 and it's probably fair to say that it's (at least) feature-equivalent to the API v1 since v0.19.0. At the time when v0.16.0 was released, the CHANGELOG stated that v1 would be removed in v0.18.0. Obviously it hasn't happened yet and this issue is to discuss if/when it should happen.

cc @roidelapluie @beorn7

xref prometheus/prometheus#8398

@beorn7
Copy link
Member

beorn7 commented Jan 29, 2021

Good to know that the API v1 removal had been announced long ago.

Yes, it would be great to retire v1 as soon as reasonably possible. It's existence caused us a lot of headache when adding new features.

@beorn7
Copy link
Member

beorn7 commented Jan 29, 2021

Also, let's remember to remove any json tags and json marshalling code that are not needed anymore after the removal (if that applies to any).

@gotjosh
Copy link
Member

gotjosh commented Feb 4, 2021

I'll be happy to take care of this.

@beorn7
Copy link
Member

beorn7 commented Feb 5, 2021

Great. Just note that we should coordinate this with prometheus/prometheus#8398 , i.e. ideally we only remove the v1 API once Prometheus defaults to the v2 API to avoid friction.

@gotjosh
Copy link
Member

gotjosh commented Jun 27, 2022

Consensus was reached during the Alertmanger Working Group that we'll proceed with this but keep the api/v1/alerts endpoint as a redirect to the api/v2/alerts endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants